Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rez-pip does not create variants with a consistent order, potentially causing duplicates. #1414

Open
jopollack opened this issue Nov 22, 2022 · 0 comments · May be fixed by #1832
Open

rez-pip does not create variants with a consistent order, potentially causing duplicates. #1414

jopollack opened this issue Nov 22, 2022 · 0 comments · May be fixed by #1832
Labels
bug rez-pip ingesting py pkgs into rez (pip, wheels, etc)

Comments

@jopollack
Copy link

Unsure of what specific code is going wrong under the hood, but rez-pip is clearly not ordering the list of packages in its variants prior to creating the package, which can create duplicates with slightly different ordering. In this case, I installed google_api_core twice, and was confused when the second wasn't ignored for already existing. Then I noticed the variants looked like this:

variants = [
    ['python-2.7', 'protobuf-3.12.0+<3.18.0', 'futures-3.2.0+'],
    ['python-2.7', 'futures-3.2.0+', 'protobuf-3.12.0+<3.18.0']
]

Environment

  • OS Linux CentOS7
  • Rez version 2.106.0
  • Rez python version 3.7.7

To Reproduce

  1. rez-pip google_api_core -i -p /temp_directory/rez --python-version 2.7
  2. repeat the above again.

Expected behavior
The same install steps should be recognized as identical and skipped as already existing.

Actual behavior
The package gets installed again, with identical variants in a slightly different order, which I expect to cause unexpected and undesirable behavior when attempting to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rez-pip ingesting py pkgs into rez (pip, wheels, etc)
Projects
None yet
2 participants