Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent v0.9.16 Substrate deps #1853

Closed
shaunxw opened this issue Feb 8, 2022 · 4 comments · Fixed by #1854
Closed

Inconsistent v0.9.16 Substrate deps #1853

shaunxw opened this issue Feb 8, 2022 · 4 comments · Fixed by #1854
Assignees
@zqhxuyuan

Comments

@shaunxw
Copy link
Contributor

shaunxw commented Feb 8, 2022

Some Substrate deps in Cargo.lock are 4aeb95f7f38fcd519e2628f32f79044a8fef99d5, but some others are 1c2332db8b6784d10bba55db794c5476aa49732a. This is probably because new introduced deps are not included in cargo patch.

We need to check Cargo.lock and make sure all deps are included in patch.
@zqhxuyuan
Copy link
Contributor

relates to: nutsfinance/stable-asset#16

@zqhxuyuan zqhxuyuan mentioned this issue Feb 8, 2022
Merged
@shaunxw
Copy link
Contributor Author

shaunxw commented Feb 8, 2022

The same issue exists with Cumulus and Polkadot deps. Search polkadot?branch= and cumulus?branch= in Cargo.lock

@zqhxuyuan
Copy link
Contributor

zqhxuyuan commented Feb 8, 2022 •
edited
Loading

👍 should be all using ?rev, the new introduced deps is mainly by test-service, I'll add it.

@shaunxw
Copy link
Contributor Author

shaunxw commented Feb 8, 2022

They should be ?rev if covered in patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zqhxuyuan zqhxuyuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update v0.9.16 AcalaNetwork/Acala
2 participants
@zqhxuyuan @shaunxw