Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] bulk update notification email addresses #984

Open
JoernBerkefeld opened this issue Jun 7, 2023 · 0 comments · May be fixed by #1066
Open

[FEATURE] bulk update notification email addresses #984

JoernBerkefeld opened this issue Jun 7, 2023 · 0 comments · May be fixed by #1066
Assignees
@phjulia
Labels
c/automation COMPONENT c/importFile COMPONENT e/Auditing EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Milestone
8

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Jun 7, 2023 •
edited
Loading

related to #983

idea is, we give it a BU, a type and optionally keys
we then need to supply the email address(es) we want the message to be send to, an optional message (not relevant for all types) and the script then goes and sets it for all relevant keys and types

for those types that have 2 options of notifications (automation with Complete and Error) we need to be able to supply different values for the email address(es) and messages.

the log should clearly show what the previous value was or if no change was necessary (and then skip the update callout)
@JoernBerkefeld JoernBerkefeld added enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" e/Auditing EPIC c/automation COMPONENT c/importFile COMPONENT NEW not yet analyzed new issues get this label labels Jun 7, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.2.0 milestone Jun 7, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.2.0, 5.3.0 Jul 11, 2023
@phjulia phjulia self-assigned this Aug 1, 2023
phjulia added a commit that referenced this issue Aug 3, 2023
@phjulia
#984: setNotifEmailAddr command added
b09acd1
phjulia added a commit that referenced this issue Aug 3, 2023
@phjulia
#984: added a function to update notifications for Automations
000778e
@phjulia phjulia linked a pull request Aug 3, 2023 that will close this issue
Open
4 tasks
@phjulia phjulia linked a pull request Aug 5, 2023 that will close this issue
Feature/984: bulk update notification email addresses #1066
Open
4 tasks
phjulia added a commit that referenced this issue Aug 7, 2023
@phjulia
#984: move updateNotifications under runMethod
76dda3e
phjulia added a commit that referenced this issue Aug 7, 2023
@phjulia
#984: enable updating notes or email addresses, additional checks, mo…
49440b9 
…ved repetitive code into a method
phjulia added a commit that referenced this issue Aug 7, 2023
@phjulia
#984: added 2 test cases for updateNotifications
10a3fe3
@JoernBerkefeld JoernBerkefeld removed the NEW not yet analyzed new issues get this label label Aug 8, 2023
phjulia added a commit that referenced this issue Aug 12, 2023
@phjulia
#984: updated function name
19f1318
phjulia added a commit that referenced this issue Aug 12, 2023
@phjulia
#984: updateNotifications improvements
24543f0
phjulia added a commit that referenced this issue Aug 13, 2023
@phjulia
#984: fixed tests, adjusted logic to set some notifications, check if…
0f1c3fe 
… notifs exist etc
phjulia added a commit that referenced this issue Aug 13, 2023
@phjulia
#984: fixed tests - +2 api requests because there is a new test autom…
48e37e1 
…ation
phjulia added a commit that referenced this issue Aug 13, 2023
@phjulia
#984: moved repetitive code into #getEncodedAutomationIDs()
e7c93c2
phjulia added a commit that referenced this issue Aug 13, 2023
@phjulia
#984: added interactive questions, no email validation at this point
92dfd6e
phjulia added a commit that referenced this issue Aug 13, 2023
@phjulia
#984: corrected test
9934cbd
phjulia added a commit that referenced this issue Aug 14, 2023
@phjulia
#984: remove notifications option
83f679d
phjulia added a commit that referenced this issue Aug 14, 2023
@phjulia
#984: added email validator
ae4cc5d
phjulia added a commit that referenced this issue Aug 14, 2023
@phjulia
#984: added a test for importFile
309de98
phjulia added a commit that referenced this issue Aug 20, 2023
@phjulia
#984: added a test for --clear option
94d8c11
phjulia added a commit that referenced this issue Aug 20, 2023
@phjulia
#984: +1 test automations, the rest of the tests were adapted
ceefc04
phjulia added a commit that referenced this issue Aug 20, 2023
@phjulia
#984: --clear option for importFile
127e1e4
phjulia added a commit that referenced this issue Aug 26, 2023
@phjulia
#984: renamed test cases
695afb0
phjulia added a commit that referenced this issue Aug 26, 2023
@phjulia
#984: split a test case into 2
fc03b1d
phjulia added a commit that referenced this issue Aug 26, 2023
@phjulia
#984: split a test case into 3
729eb96
phjulia added a commit that referenced this issue Aug 27, 2023
@phjulia
#984: +3 tests for clearNotifications (+3 cached automations, +6 API …
f691e6c 
…calls)
phjulia added a commit that referenced this issue Aug 27, 2023
@phjulia
#984: improved regex email validation
3023492
phjulia added a commit that referenced this issue Aug 27, 2023
@phjulia
#984: moved type specific stuff into child class
9abe1e5
phjulia added a commit that referenced this issue Aug 27, 2023
@phjulia
#984: removed options from updateNotifications command
1609171
phjulia added a commit that referenced this issue Aug 28, 2023
@phjulia
#984: added a test for updating a note only
9bb5be7
phjulia added a commit that referenced this issue Aug 28, 2023
@phjulia
#984: +1 automation
0dc51ae
phjulia added a commit that referenced this issue Aug 30, 2023
@phjulia
#984: added a function to retrieve and deploy that is used for fixKey…
23d0cea 
…s and updateNotifications
phjulia added a commit that referenced this issue Aug 30, 2023
@phjulia
#984: regex for email validation replaced
12f7b3d
phjulia added a commit that referenced this issue Aug 30, 2023
@phjulia
#984: add questions to an array
fe22dca
phjulia added a commit that referenced this issue Aug 30, 2023
@phjulia
#984: validate added
0b43078
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.3.0, 5.4.0 Aug 31, 2023
phjulia added a commit that referenced this issue Aug 31, 2023
@phjulia
#984: test cases
9ddbefe
phjulia added a commit that referenced this issue Aug 31, 2023
@phjulia
#984: +15 automations/+15 API calls
c18e6ef
phjulia added a commit that referenced this issue Sep 3, 2023
@phjulia
#984: fixed issue with email validation
7b0de99
@JoernBerkefeld JoernBerkefeld modified the milestones: 6.2.0, 6.1.0 Sep 22, 2023
phjulia added a commit that referenced this issue Sep 24, 2023
@phjulia
#984: merge develop into branch
1101102
JoernBerkefeld added a commit that referenced this issue Oct 9, 2023
@JoernBerkefeld
#984: improve log message for updateNotification
258c067
JoernBerkefeld added a commit that referenced this issue Oct 9, 2023
@JoernBerkefeld
#984: move updateNotification logic from custom createOrUpdate into p…
63f9784 
…reDeployTasks
JoernBerkefeld added a commit that referenced this issue Oct 10, 2023
@JoernBerkefeld
#984: rename importFile test for updateNotification
8e2670a
JoernBerkefeld added a commit that referenced this issue Feb 26, 2024
@JoernBerkefeld
#984: refactoring
9981086
JoernBerkefeld added a commit that referenced this issue Feb 27, 2024
@JoernBerkefeld
#984: fix tests for importFile & query
6626df6
@JoernBerkefeld JoernBerkefeld modified the milestones: 6.1.0, 6.2.0 May 15, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.2.0, 7.3.0 Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phjulia phjulia

Labels
c/automation COMPONENT c/importFile COMPONENT e/Auditing EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
8
Development

Successfully merging a pull request may close this issue.

Feature/984: bulk update notification email addresses Accenture/sfmc-devtools
2 participants
@JoernBerkefeld @phjulia