Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] update onLoop to expect array instead of object #676

Closed
JoernBerkefeld opened this issue Jan 27, 2023 · 1 comment · Fixed by #673
Closed

[TASK] update onLoop to expect array instead of object #676

JoernBerkefeld opened this issue Jan 27, 2023 · 1 comment · Fixed by #673
Assignees
@JoernBerkefeld
Labels
chore Jira issue-type "Task" SFMC-SDK
Milestone
4.3.0

Comments

@JoernBerkefeld
Copy link
Contributor

the to-be released version of sfmc-sdk now does what the docs say and actually passes an array of so far retrieved items to onLoop as second parameter.

we currently expect an object with 2 or 3 different attributes, depending on the request, in which the actual array is located. we then get its length.

going forward, we can just get the length of the parameter directly.
@JoernBerkefeld JoernBerkefeld added chore Jira issue-type "Task" SFMC-SDK labels Jan 27, 2023
@JoernBerkefeld JoernBerkefeld added this to the 4.3.0 milestone Jan 27, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jan 27, 2023
@JoernBerkefeld JoernBerkefeld linked a pull request Jan 27, 2023 that will close this issue
Bugfix/672 only first 50 transactionalx are retrieved + #676 onLoop fix + sfmc-sdk bump to 0.6.3 #673
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld mentioned this issue Jan 27, 2023
Merged
4 tasks
@github-actions
Copy link

Closed by #673.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
chore Jira issue-type "Task" SFMC-SDK
Projects
None yet
Milestone
4.3.0
1 participant
@JoernBerkefeld