Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cdp command does not identify changes in files of a certain type #757

Closed
1 of 2 tasks
phjulia opened this issue Feb 20, 2023 · 3 comments · Fixed by #762 or #764
Closed
1 of 2 tasks

[BUG] cdp command does not identify changes in files of a certain type #757

phjulia opened this issue Feb 20, 2023 · 3 comments · Fixed by #762 or #764
Assignees
Labels
bug Something isn't working c/asset COMPONENT e/DevOps EPIC PRIORITY used for professional service clients
Milestone

Comments

@phjulia
Copy link
Collaborator

phjulia commented Feb 20, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

cdp command did not copy all blocks in messages. For example:
retrieve/.../Estonia/asset/message/0b2c92b2-2ac7-4a37-b9aa-997b8743fd7e/blocks/views.html.slots.[bottom-4zg3bgzu4r3].asset-message-meta.html
The issue was identified by retrieving a list of changed files via git, counting the number of files copied by cpd and comparing the numbers. The number of files missing (16) was the same as the number of blocks within messages in git log.

Expected Behavior

No response

Steps To Reproduce

  1. Install npm i -g accenture/sfmc-devtools#cdp
  2. run mcdev cdp --filter '.../countryNameHere/asset'

Version

develop-branch

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response

@phjulia phjulia added bug Something isn't working NEW not yet analyzed new issues get this label labels Feb 20, 2023
@JoernBerkefeld JoernBerkefeld added e/DevOps EPIC PRIORITY used for professional service clients c/asset COMPONENT labels Feb 20, 2023
@JoernBerkefeld
Copy link
Contributor

i can confirm that comparing the 2 commits in git it lists changes in views.html... file AND the json - yet, in the deploy folder i only see the json:

git:
image
vs
mcdev:
image

@JoernBerkefeld JoernBerkefeld self-assigned this Feb 21, 2023
@JoernBerkefeld JoernBerkefeld removed the NEW not yet analyzed new issues get this label label Feb 21, 2023
@JoernBerkefeld
Copy link
Contributor

the problem occurred when the filename included dots. also would have happened for files that didn not include the standard .type-meta.xyz ending

@github-actions
Copy link

Closed by #762.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment