AT-SPI Accessible is missing get_role_name and get_localized_role_name

[wash2]

get_localized_role_name is called by accerciser for every node and if it is not implemented, the application and its accessibility tree don't show up at all in accerciser. I've added a simple implementation for each here https://github.com/wash2/accesskit/tree/iced and I'd be happy to make a PR with the changes, but also it might be good to come up with a solution which can localize role names 😅

[DataTriny]

Indeed, i18n is the reason why I initially skipped these methods as we haven't made a choice here yet.
Accerciser's behaviour is bad IMO though, because in reality ATs will provide the role name most of the time.

[wash2]

Ok gotcha!

[DataTriny]

So I made more tests today and my initial assumption was wrong. Given how GetLocalizedRoleName's documentation was phrased, I thought we could return an empty string to signal that libatspi should use its own translation string instead.

Unfortunately it is not the case currently. I'll see if I can change libatspi's behavior, but don't expect a quick fix.

I have a branch in which I updated to the latest atspi version and added the missing methods, get_localized_role_name simply returning the role name as provided by the atspi crate. With this our example program shows up in accerciser.

Is it worth adding this broken implementation while we wait for a proper fix? @mwcampbell

[DataTriny]

Progress on the GNOME side can be tracked here: GNOME/at-spi2-core#110.

[DataTriny]

Underlying AT-SPI issue was closed. Our winit example now shows up on Accerciser when using at-spi2-core master. Once you have cloned the repo, instructions for how to build and install can be found here.

Now of course this mean that it won't work for anyone using the current version. Given the state of AT-SPI and how much it is predicted to change, doing backports on our side will be a nightmare. If compatibility with older GNOME is a feature we want, then this issue is still relevant, otherwise it can be closed.

CC @lunixbochs

[lunixbochs]

My vote would be at minimum for compatibility with any currently supported ubuntu LTS, so I'd prefer a workaround until that atspi version is EOL.

[lunixbochs]

I wouldn't mind having this mitigated, as it currently means anyone not on bleeding edge at-spi2-core (including me) can't use Accerciser from their package manager to test Accesskit apps.

[DataTriny]

@lunixbochs now that the upstream issue is fixed, if we provide non-localized role names they will replace more useful (localized) values provided by libatspi. Solving your issue would require checking which version of the AT-SPI daemon is running on the system.

We understand that this is a serious issue for testers though, I'll investigate this some more.