Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility of asNavFor setting #17

Closed
jasonwebb opened this issue Aug 21, 2020 · 1 comment
Closed

Improve accessibility of asNavFor setting #17

jasonwebb opened this issue Aug 21, 2020 · 1 comment
Labels
feature change Change to an existing feature or functionality

Comments

@jasonwebb
Copy link

Two different sliders can be linked together using the asNavFor setting, which generally means twice the confusion for screen reader and keyboard-only users. This setting is often used on e-commerce PDP pages to display an enlarged product image next to a set of thumbnail images.

@jasonwebb jasonwebb added the feature change Change to an existing feature or functionality label Aug 21, 2020
@jasonwebb
Copy link
Author

jasonwebb commented Sep 9, 2020

Since its not really possible to implicitly determine exactly how or why this functionality is used when a developer chooses to use it, I'm thinking that there is no universal accessibility enhancement that can be safely baked in to the package.

Instead, I've added a new setting in #18 (instructionsText) that allows developers to pass in some instructional text to explain any complex functionality in their use case, and added some notes strongly encouraging people to use this new setting when using asNavFor or any of the API methods/events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature change Change to an existing feature or functionality
Projects
None yet
Development

No branches or pull requests

1 participant