forked from kenwheeler/slick
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard Coded Labels #51
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi. I love the accessible sliders. It is about time we can offer them to our clients and to page builder authors. Great job!!
One issue that bothers me is the hard coded labels. All labels are implemented using aria-label. It would have been much more effective to provide a unique ID on the content of the slide and use aria-labelledby on each of the groups. The screen readers will announce the real content (text content, alt content etc.) instead of the slide number.
The text was updated successfully, but these errors were encountered: