Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous / next buttons do not give any feedback to screen reader when being pressed #70

Open
jmuheim opened this issue Jun 6, 2022 · 2 comments

Comments

@jmuheim
Copy link

jmuheim commented Jun 6, 2022

I'm currently looking for an accessible slider carousel for a client.

Thanks for creating this great implementation, it look really good. But I have one thing to complain:

When I press the "Previous" or "Next" button, no feedback is given to the screen reader. Wouldn't it make sense to give the button a label like Next (slides 1 to 3), and when pressed, update it to Next (slides 4 to 6)? At least some screen readers will then announce the changed label, AFAIK.

One could argue, that it is not that much important to give a feedback, and I'd agree: the user will find out quickly that the visible slides actually changed by navigating around. But at least for the following scenario, the current implementation is very confusing:

For the "Responsive Display", when I press the "Next" button, I get "unavailable" (as it is disabled now). The user might be very confused now: what is unavailable? Did pressing the button actually work? Or what happened exactly?

CleanShot 2022-06-06 at 17 17 49@2x

That's just an edge case, and after navigating around a little bit the user will find out what's going on. But still, I think that setting a proper label would enhance the issue, i.e. Next slide (last).

Thank you.

@jmuheim
Copy link
Author

jmuheim commented Jun 6, 2022

Thinking about it, it may be a good idea to put an aria-live="polite" around the slide, so it would announce the currently displayed slide automatically. This would kind-of "fix" the mentioned issue, and improve general usability for blind people (except when auto-rotating the slides, the live region should be removed).

@webgurumike
Copy link

Thinking about it, it may be a good idea to put an aria-live="polite" around the slide, so it would announce the currently displayed slide automatically. This would kind-of "fix" the mentioned issue, and improve general usability for blind people (except when auto-rotating the slides, the live region should be removed).

What if there are multiple slides visible? This would read them all, no? I tried this method and it even reads the first slide that has been scrolled out of view as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants