Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Make Prompt Parameter in Custom Workflows more usable. #1380

Open
leha-games opened this issue Nov 11, 2024 · 4 comments
Open

Comments

@leha-games
Copy link

leha-games commented Nov 11, 2024

I really like the new custom workflows feature. Amazing work as always!

But prompt parameter node can be made way more usable if it outputs not only text, but also includes loras that in the prompt (it already has loras autocompletion in this field).

I see it like this. There is a new node that has three inputs: model, clip and text append (because we need to append prompts from Krita Style node) and output something like MODEL, CLIP, and STRING of text without lora tags.

Also it would be super amazing if it syncs prompt values with other modes like Generate, Live, Animation.

Thanks!

P.S. Or maybe just a checkbox in Krita Style node (prompt inputs: true/false), and no need for a new node

image

@RadioVs
Copy link

RadioVs commented Nov 13, 2024

A Style node have prompt outputs which is useless now, it would be good if this node came with a prompt window as in normal mode.
Something like this:
image

@leha-games
Copy link
Author

it would be good if this node came with a prompt window as in normal mode.

Yes, I like the idea

@Acly
Copy link
Owner

Acly commented Nov 18, 2024

The positive/negative outputs of the style nodes are the templates configured in the style.
You can merge them with an actual prompt from a separate parameter, or ignore them, or merge them and pass them to some other encoder, or a wildcard node, or some LLM, etc. - before you CLIP encode them.

The main purpose is to give full control & flexibility, so I think the current behavior is fine. It might make sense to offer some high level nodes for convenience. But they'd likely duplicate some functionality that already exists in Comfy or other custom nodes.

@leha-games
Copy link
Author

leha-games commented Nov 18, 2024

The main purpose is to give full control & flexibility, so I think the current behavior is fine. It might make sense to offer some high level nodes for convenience. But they'd likely duplicate some functionality that already exists in Comfy or other custom nodes.

You are absolutely right.

But I really like the convenience of your innovative plugin.

As an example I have a custom workflow where I can upscale image to 4k or maybe 8k with an upscaler and then Tiled Diffusion with control net. It would be useful if prompts is synced with Generate Mode. You can just switch to custom workflow any time and hit generate to get 8k. No need to copy-paste prompts.

And by the way you have custom lora paths searching code. I have to modify LoRA Tag Loader for ComfyUI extension to get similar behavior of inserting loras from text prompt.

So it would be nice if

  1. Syncing prompts between modes
  2. Loading loras from prompt identically as in other modes.

Thanks. Your work is really top notch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants