Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLEASE simplify the model structure/requirements #1418

Open
bbecausereasonss opened this issue Nov 18, 2024 · 4 comments
Open

PLEASE simplify the model structure/requirements #1418

bbecausereasonss opened this issue Nov 18, 2024 · 4 comments

Comments

@bbecausereasonss
Copy link

I really want to use this, but am already a full-time comfy/forge user. I have my own folder structure for my models. I and likely many others need a simple interface where we can point to the core models for Krita to work without the entire thing just failing. I should be able to select which Fux/SDL model I want to load as base, which VAE's etc. This is how all other plugins (SD) work in Photoshop etc.

@BugReporterZ
Copy link

BugReporterZ commented Nov 20, 2024

I'd agree. Recently I've been using NoobAI XL (an Illustrious XL continued pretrain), and I had to rename its official control net files because apparently filenames are hardcoded in krita-ai-diffusion.

@bbecausereasonss
Copy link
Author

It's best practice to use hash's instead of file-names where possible, or just not hard code the file-names and allow us to link manually.

@Acly
Copy link
Owner

Acly commented Nov 20, 2024

It is as simple as it gets though. The folders are defined by ComfyUI. You download the model, put it in the correct folder and it will work. Sometimes there's one with a generic name (model.safetensors) that needs renaming.

I'd argue it works fine for most people without complex custom setups, and doesn't require you to setup paths for 50+ supported models manually (which would be super tedious and frankly unacceptable).

Search paths are here: https://github.com/Acly/krita-ai-diffusion/blob/main/ai_diffusion/resources.py#L872-L927

You could put additional filenames in a separate JSON, load them and add them to the front of the list. Make a PR.

A UI would add a lot of complexity for relatively little gain...

It's best practice to use hash's instead of file-names where possible

Comfy doesn't provide hashes, and hashing people's (sometimes gigantic) model directories can take minutes. There's often slightly different versions of the same model too, maintaining hashes doesn't sound practical.

I do wish there was a better way than filenames, but there's no standards or meta information, everyone throws out models with slightly different architecture and conventions.

@BugReporterZ
Copy link

BugReporterZ commented Nov 20, 2024

Although they share the basic architecture, some popular illustration models (Pony XL, Illustrious) aren't fully compatible with the base they come from (SDXL); ultimately it would really be best if specific control nets, inpaint models, (etc.) could optionally be associated on a per-model basis (or more realistically, style preset).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants