fix: fixed browser/editor bucket fallback to host 'unknown'

ActivityWatch · Jul 18, 2022 · 9d4a638 · 9d4a638 · github-actions · Jul 18, 2022
1 parent cf2476c
commit 9d4a638
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/src/stores/buckets.ts b/src/stores/buckets.ts
@@ -78,17 +78,23 @@ export const useBucketsStore = defineStore('buckets', {
       // fallback to a bucket with 'unknown' host, if one exists.
       // TODO: This needs a fix so we can get rid of this workaround.
       const type = 'app.editor.activity';
-      return (host: string) =>
-        select_buckets(this.buckets, { host, type }) ||
-        select_buckets(this.buckets, { host: 'unknown', type });
+      return (host: string) => {
+        const buckets = select_buckets(this.buckets, { host, type });
+        return buckets.length == 0
+          ? select_buckets(this.buckets, { host: 'unknown', type })
+          : buckets;
+      };
     },
     bucketsBrowser() {
       // fallback to a bucket with 'unknown' host, if one exists.
       // TODO: This needs a fix so we can get rid of this workaround.
       const type = 'web.tab.current';
-      return (host: string) =>
-        select_buckets(this.buckets, { host, type }) ||
-        select_buckets(this.buckets, { host: 'unknown', type });
+      return (host: string) => {
+        const buckets = select_buckets(this.buckets, { host, type });
+        return buckets.length == 0
+          ? select_buckets(this.buckets, { host: 'unknown', type })
+          : buckets;
+      };
     },
 
     getBucket() {