Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added category-builder to easily make categories from uncategorized time (and a notification when much is uncategorized) #378

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Oct 17, 2022

Fetches recent uncategorized events and finds the most common words (by time) which may then be used to create or append category rules with the click of a button.

Also includes a new notification on the Activity view if there's high uncategorized activity (>20%).

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 25.69% // Head: 25.35% // Decreases project coverage by -0.33% ⚠️

Coverage data is based on head (b4d49e2) compared to base (033ad99).
Patch coverage: 8.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   25.69%   25.35%   -0.34%     
==========================================
  Files          26       26              
  Lines        1448     1471      +23     
  Branches      229      235       +6     
==========================================
+ Hits          372      373       +1     
- Misses       1046     1068      +22     
  Partials       30       30              
Impacted Files Coverage Δ
src/route.js 0.00% <0.00%> (ø)
src/stores/activity.ts 31.02% <0.00%> (-1.18%) ⬇️
src/stores/categories.ts 57.14% <0.00%> (-6.02%) ⬇️
src/queries.ts 47.78% <66.66%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ErikBjare ErikBjare force-pushed the dev/category-builder branch from 7370691 to b4d49e2 Compare October 18, 2022 10:28
@@ -0,0 +1,32 @@
<template lang="pug">
div
// TODO: Add some way to disable this notification, probably by making the ratio threshold configurable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised the ratio threshold to 20%, might be high enough to not need a disable feature (for now).

@ErikBjare
Copy link
Member Author

This is basically done, will merge and do any final fixes on master if needed.

Nice to finally have a fast way to create categories.

@ErikBjare ErikBjare changed the title feat: added WIP category-builder to easily make categories from uncategorized time feat: added category-builder to easily make categories from uncategorized time Oct 18, 2022
@ErikBjare ErikBjare changed the title feat: added category-builder to easily make categories from uncategorized time feat: added category-builder to easily make categories from uncategorized time (and a notification when much is uncategorized) Oct 18, 2022
@ErikBjare ErikBjare merged commit 74778e0 into master Oct 18, 2022
@ErikBjare ErikBjare deleted the dev/category-builder branch October 18, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant