-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly invert colors of alerts in dark mode #591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 67db254 in 21 seconds
More details
- Looked at
21
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. static/dark.css:11
- Draft comment:
The change to exclude.close
buttons from the color styling in dark mode is correctly implemented using the:not()
CSS pseudo-class. This ensures that the close buttons retain their original styling, making them visually distinct, which is important for usability. - Reason this comment was not posted:
Confidence changes required:0%
The PR aims to exclude the close button from the color change applied to other buttons in dark mode. The selector used isbutton:not(.close)
, which is intended to apply the color#e9ebf0
to all buttons except those with the class.close
. This seems to be a targeted change to maintain the original color of the close button in alerts or modals, likely because the dark mode color makes it less visible or aesthetically pleasing. The change is straightforward and appears to be correctly implemented based on the CSS selector used.
Workflow ID: wflow_W3ZsZlsLBORxmJHq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #591 +/- ##
=======================================
Coverage 26.13% 26.13%
=======================================
Files 27 27
Lines 1630 1630
Branches 281 286 +5
=======================================
Hits 426 426
- Misses 1145 1178 +33
+ Partials 59 26 -33 ☔ View full report in Codecov by Sentry. |
This is great, but I wonder if we should instead make the popup less bright/a darker red (and a brighter text). |
Very nice! Merging 🎉 |
Before:
After:
Summary:
Exclude the close button from color changes in dark mode by updating
static/dark.css
.Key points:
static/dark.css
to exclude.close
button from color changesbody, button, html, table
selector tobody, button:not(.close), html, table
Generated with ❤️ by ellipsis.dev