Apply clang tidy fix to entire code base (Part 2) (moveit#1394)

* Conform class name to `CamelCase`

* Conform member method name to `camelBack`

* Exceptions to method name

* Conform local variable name to `lower_case` part 1

* Conform local variable name to `lower_case` part 2

* Conform local variable name to `lower_case` part 3

* Conform local variable name to `lower_case` part 4

* Local static variable to `lower_case`

* Local variable manual fix

* Exceptions to local variable name

* Conform static const variable name to `UPPER_CASE`

* Conform global variable name to `UPPER_CASE`

* Conform static const member variable to `UPPER_CASE`

* clang-format

* Travis: mandatory clang-tidy-check

* Catch up most recent changes

* Update .clang-tidy

* fixup! Conform static const variable name to `UPPER_CASE`

Author: RoboticsYY

.clang-tidy

@@ -11,6 +11,7 @@ Checks:          '-*,
                   readability-redundant-string-cstr,
                   readability-simplify-boolean-expr,
                   readability-container-size-empty,
+                  readability-identifier-naming,
                   '
 HeaderFilterRegex: ''
 AnalyzeTemporaryDtors: false

.travis.yml

@@ -34,10 +34,6 @@ matrix: # Add a separate config to the matrix, using clang as compiler
            BEFORE_DOCKER_SCRIPT="source moveit_kinematics/test/test_ikfast_plugins.sh"
            CXXFLAGS="-Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wredundant-decls -Wno-unused-parameter -Wno-unused-function -Wno-overloaded-virtual"
 
-  fast_finish: true  # finish, even if allow-failure-tests still running
-  allow_failures:
-    - env: TEST=clang-tidy-fix  # need to fix clang-tidy issues
-
 before_script:
   - git clone -q --depth=1 https://github.com/ros-planning/moveit_ci.git .moveit_ci
 

moveit_core/collision_detection/include/moveit/collision_detection/allvalid/collision_detector_allocator_allvalid.h

@@ -49,7 +49,7 @@ class CollisionDetectorAllocatorAllValid
                                                 CollisionDetectorAllocatorAllValid>
 {
 public:
-  static const std::string NAME_;  // defined in collision_world_allvalid.cpp
+  static const std::string NAME;  // defined in collision_world_allvalid.cpp
 };
 }
 

moveit_core/collision_detection/include/moveit/collision_detection/collision_detector_allocator.h

@@ -78,7 +78,7 @@ class CollisionDetectorAllocatorTemplate : public CollisionDetectorAllocator
 public:
   const std::string& getName() const override
   {
-    return CollisionDetectorAllocatorType::NAME_;
+    return CollisionDetectorAllocatorType::NAME;
   }
 
   CollisionWorldPtr allocateWorld(const WorldPtr& world) const override

moveit_core/collision_detection/src/allvalid/collision_world_allvalid.cpp

@@ -146,4 +146,4 @@ void collision_detection::CollisionWorldAllValid::distanceWorld(const collision_
 }
 
 #include <moveit/collision_detection/allvalid/collision_detector_allocator_allvalid.h>
-const std::string collision_detection::CollisionDetectorAllocatorAllValid::NAME_("ALL_VALID");
+const std::string collision_detection::CollisionDetectorAllocatorAllValid::NAME("ALL_VALID");

moveit_core/collision_detection_fcl/include/moveit/collision_detection_fcl/collision_detector_allocator_fcl.h

@@ -48,7 +48,7 @@ class CollisionDetectorAllocatorFCL
     : public CollisionDetectorAllocatorTemplate<CollisionWorldFCL, CollisionRobotFCL, CollisionDetectorAllocatorFCL>
 {
 public:
-  static const std::string NAME_;  // defined in collision_world_fcl.cpp
+  static const std::string NAME;  // defined in collision_world_fcl.cpp
 };
 }
 

moveit_core/collision_detection_fcl/src/collision_world_fcl.cpp

@@ -54,7 +54,7 @@
 
 namespace collision_detection
 {
-const std::string CollisionDetectorAllocatorFCL::NAME_("FCL");
+const std::string CollisionDetectorAllocatorFCL::NAME("FCL");
 
 CollisionWorldFCL::CollisionWorldFCL() : CollisionWorld()
 {

moveit_core/collision_distance_field/include/moveit/collision_distance_field/collision_detector_allocator_distance_field.h

@@ -49,7 +49,7 @@ class CollisionDetectorAllocatorDistanceField
                                                 CollisionDetectorAllocatorDistanceField>
 {
 public:
-  static const std::string NAME_;  // defined in collision_world_distance_field.cpp
+  static const std::string NAME;  // defined in collision_world_distance_field.cpp
 };
 }
 

moveit_core/collision_distance_field/include/moveit/collision_distance_field/collision_detector_allocator_hybrid.h

@@ -49,7 +49,7 @@ class CollisionDetectorAllocatorHybrid
                                                 CollisionDetectorAllocatorHybrid>
 {
 public:
-  static const std::string NAME_;  // defined in collision_world_hybrid.cpp
+  static const std::string NAME;  // defined in collision_world_hybrid.cpp
 };
 }
 

moveit_core/collision_distance_field/src/collision_world_distance_field.cpp

@@ -566,4 +566,4 @@ CollisionWorldDistanceField::DistanceFieldCacheEntryPtr CollisionWorldDistanceFi
 }  // namespace collision_detection
 
 #include <moveit/collision_distance_field/collision_detector_allocator_distance_field.h>
-const std::string collision_detection::CollisionDetectorAllocatorDistanceField::NAME_("DISTANCE_FIELD");
+const std::string collision_detection::CollisionDetectorAllocatorDistanceField::NAME("DISTANCE_FIELD");