Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain Cycles #25

Open
Coledunsby opened this issue Apr 15, 2021 · 0 comments
Open

Retain Cycles #25

Coledunsby opened this issue Apr 15, 2021 · 0 comments

Comments

@Coledunsby
Copy link

There are several retain cycles in AdaWebHost:

  • reachability.whenReachable closure
  • DispatchQueue.main.asyncAfter closure
  • userContentController.add(self, name: "...") (x3)

I started resolving these (#24) but realized that this would likely break the scenario of launching the view controller multiple times from the same AdaWebHost instance. I would prefer to use AdaWebHost as a non singleton instance but the retain cycles currently prevent that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant