drag tab outside should be result into an new window :)

[boonkerz]

nice to have i think :)

link maybe help:
https://github.com/vivlim/egui-glow-multiwin

[Adanos020]

Agree, this feature is going to be crucial to get the library to a usable state

[Jerrody]

It can be done with:
https://docs.rs/egui/latest/egui/containers/struct.Window.html

egui::Window::new("My Window").show(ctx, |ui| {
   ui.label("Hello World!");
});

Another part is how to determine that the tab is should be the new window.

[Adanos020]

One way of achieving this effect is to imitate Dear Imgui.

While the tab is being dragged outside of the tab bar, it is a new window until you drop it while hovering over one of these icons that show up in the middle of the node you're currently hovering over. If it's dropped anywhere else, it stays as a window.

We might consider implementing this for all egui::Windows or creating our custom egui_dock::DockableWindow (or whatever we're gonna call it) instead.

[Jerrody]

One way of achieving this effect is to imitate Dear Imgui.

While the tab is being dragged outside of the tab bar, it is a new window until you drop it while hovering over one of these icons that show up in the middle of the node you're currently hovering over. If it's dropped anywhere else, it stays as a window.

We might consider implementing this for all egui::Windows or creating our custom egui_dock::DockableWindow (or whatever we're gonna call it) instead.

If we are going to do this it will require big changes.

[Adanos020]

Definitely. But I think it's going to be worth it as it would make using the docking UI much easier.

Of course, I'm open to other ideas too, this one's just the first thing that came into my mind.

[Jerrody]

Definitely. But I think it's going to be worth it as it would make using the docking UI much easier.

Of course, I'm open to other ideas too, this one's just the first thing that came into my mind.

Or (it is simple and seems pretty elegant) it's just right-clicked on a tab and then this tab becomes an individual window.
Although it may look like a hack :P
But I think that this is not what should be.

[Jerrody]

One way of achieving this effect is to imitate Dear Imgui.

While the tab is being dragged outside of the tab bar, it is a new window until you drop it while hovering over one of these icons that show up in the middle of the node you're currently hovering over. If it's dropped anywhere else, it stays as a window.

We might consider implementing this for all egui::Windows or creating our custom egui_dock::DockableWindow (or whatever we're gonna call it) instead.

I have an idea. What if to remove this area and replace it with creating a new window?

And keep it to have the ability to attach a tab to the node.

[Adanos020]

Or (it is simple and seems pretty elegant) it's just right-click on a tab and then this tab becomes an individual window.

I have a couple problems with this idea:

• It's not nearly as intuitive to the user as pulling the tab out of the tab bar
• How would you dock the window back into a specific node?

[Adanos020]

I have an idea. What if to remove this area and replace it with creating a new window?

Can you elaborate more on the exact behaviour you have in mind? I'm not quite sure what area you mean to remove, among other things.

[Jerrody]

Can you elaborate more on the exact behaviour you have in mind? I'm not quite sure what area you mean to remove, among other things.

I mean instead of showing this fully filled selection the user will have an ability to drop a tab and create new window.

[Jerrody]

Okay, I determined how to do this.

println!("{:?} {:?}", helper.size(), hover.size());

The next thing it's how to create the window and copy content from the tab and dock back the window.

[Jerrody]

Sorry, if I explain pretty odd.

[Adanos020]

So if I understand correctly: dragging the tab looks like it does right now and dropping it in a certain spot should create a new window out of it, or dock it in a node if it's dropped in another certain spot. Is that right?

I'm not yet sure how it would feel to the user, but it's worth giving it a try!

[Jerrody]

So if I understand correctly: dragging the tab looks like it does right now and dropping it in a certain spot should create a new window out of it, or dock it in a node if it's dropped in another certain spot. Is that right?

I'm not yet sure how it would feel to the user, but it's worth giving it a try!

My current state of experiments.

[Jerrody]

It works pretty good other thing is how to translate content to the window and how to back this window to the nodes as a tab.

[Jerrody]

I think that should be great idea if to create a nightly branch where we can do experiments and others dark things :')

[Adanos020]

Good progress so far!

I think that should be great idea if to create a nightly branch where we can do experiments and others dark things :')

That's not a bad idea, I'll create one now. We can also use draft pull requests for tracking all WIP stuff.

[Jerrody]

That's not a bad idea, I'll create one now. We can also use draft pull requests for tracking all WIP stuff.

Sounds good.

[Adanos020]

Done, you can use the experimental branch :)

[smallB007]

Guys, if I may add to that discussion. If anyone wants to know how docking should behave, please look how Visual Studio (not VSCode). They (Visual Studio) simply perfected it.

[Adanos020]

Guys, if I may add to that discussion. If anyone wants to know how docking should behave, please look how Visual Studio (not VSCode). They (Visual Studio) simply perfected it.

Yes, this is the approach I would like to go with, that's why I'm suggesting to imitate Dear ImGui.

[Adanos020]

I created a discussion for this feature: #29

[gre-v-el]

nice to have i think :)

link maybe help:
https://github.com/vivlim/egui-glow-multiwin

I know this issue is pretty old, but judging by the linked repo I think the original poster meant the os window, not the egui::Window in their feature request. See the linked YouTube video in the README of the linked repo.

[micfong-z]

Upon some tweaking (with breaking changes), I'm able to make it this far (code at https://github.com/micfong-z/egui_dock/tree/main; definitely not ready for a PR), with a Dear ImGui-like overlay:

Screen.Recording.2023-06-17.at.22.16.26.mp4

I'm using a separate Vec<(Tab, Pos2)> in DockArea to store all detached windows (Pos2 used to track init position of window).

However, same as in #27, I have totally no idea how to handle the windows after they are "detached".

Maybe we should make DockArea contain a Vec<Tree<Tab>> so that all detached windows have individual Trees to handle the tabs in it, and the tabs should be able to interact with other Trees on other windows. (AFAIK, imgui gives all detached windows new tab managing areas)

I'm relatively new to Rust, and so its data structures. So there might be better solutions (?)

[Adanos020]

@micfong-z Great work, this looks incredible!

I think the issue with detached windows might be that we'd need to make changes to egui itself, so that we could "steal" the contents of any egui::Window, close it, and put them in a tab. Another option is to create our own DockableWindow and capture its instances.

It's not an easy problem to solve and will probably take a few iterations to get this right.

I also think it might be worthwhile to create a new branch just for this feature. You could then open a PR to that branch so that other people would also be able to contribute.

[Adanos020]

Closed by #149