Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordering headers does not reorder column data in >= 3.0 #899

Closed
MichalBryxi opened this issue Jul 28, 2021 · 5 comments
Closed

Reordering headers does not reorder column data in >= 3.0 #899

MichalBryxi opened this issue Jul 28, 2021 · 5 comments

Comments

@MichalBryxi
Copy link

MichalBryxi commented Jul 28, 2021

How to reproduce

Broken case

  1. In docs go to any version that is v3.x.x and above
  2. Click on "A Basic Table" section
  3. Drag and drop one of the columns to other place
  4. Notice that the header has changed position
  5. Notice that the rest of the column data did not change position
  6. Notice that the version of Ember here is v3.24.2

Working case

  1. In docs go to any version that is below v3.x.x
  2. Click on "A Basic Table" section
  3. Drag and drop one of the columns to other place
  4. Notice that the header has changed position
  5. Notice that the rest of the column data also did change position
  6. Notice that the version of Ember here is v3.12.0

Screenshots

Screenshot 2021-07-28 at 22 21 47

Screenshot 2021-07-28 at 22 18 33

@MichalBryxi
Copy link
Author

Note: In my own app where this bug is present, I use:

"ember-table": "^2.2.3",
"ember-cli": "~3.25.2",

So it seems that the bug is introduced by higher version of ember rather than higher version of ember-table.

@loxmys
Copy link

loxmys commented Aug 6, 2021

demo page has same bug
ember-table-bug

@MichalBryxi
Copy link
Author

Made me wonder whether that means that ember inspector suffers from this bug as well or not. Well it does :)

Screenshot 2021-08-11 at 23 11 40

@MichalBryxi
Copy link
Author

Fixed in v3.0.2-1 🥳

@MichalBryxi
Copy link
Author

PR that fixes this: #878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants