Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More complete basic CSS would be useful #996

Open
malcolm-3 opened this issue Aug 11, 2023 · 0 comments
Open

More complete basic CSS would be useful #996

malcolm-3 opened this issue Aug 11, 2023 · 0 comments

Comments

@malcolm-3
Copy link

First let me say that with only having started to use EmberTable a few days ago I am very impressed with the package and its documentation. I followed the very clear and useful documentation to get myself started rendering tables very quickly. However, I ran into a few problems with the rendering. For example, when I got to trying to use EmberTh::SortIndicator, no indicator was visible in my application. It took me a bit of digging with the web developer tools comparing my page to the documentation pages (where the sort indicators are visible) to find that the problem was that in the distribution there are no CSS specifications for the et-sort-indicator class.

I was able to solve my problem by just copying all of the ember-table CSS from the documentation site into my app.css file. That solved my sort indicator problem and all of the other formatting oddities I was experiencing, and provides me a good starting point for adjusting the style to meet my needs.

It would be nice, however, if the distribution came with a more complete set of basic CSS. Or if the documentation included instructions on what CSS the user is expected to provide for themselves. Or if there is a more straightforward way to get a basic functional CSS, it would be nice to have that more prominently explained in the documentation.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant