Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollable header row #8

Closed
changhiskhan opened this issue Dec 22, 2012 · 8 comments
Closed

scrollable header row #8

changhiskhan opened this issue Dec 22, 2012 · 8 comments
Assignees
Labels

Comments

@changhiskhan
Copy link

I noticed that the headers in the tree table example scrolls with the data (left and right) but the other examples with a fixed column does not (D3 sparkline example).

I tried to read through the code in the examples but couldn't figure it out.

Thanks!

@tonysherbondy
Copy link

For me the sparkline example does seem broken, but in a different way than @changhiskhan describes. It shouldn't even let you scroll horizontally as the table fits in the screen and the others that fit do not. If you resize the sparkline so that all the columns do not fit in the table viewport than it will scroll correctly.

@changhiskhan
Copy link
Author

In the sparklines example, if I resize the the browser so that the table doesn't fit all the columns then the header row scrolling works as expected.

@ghost ghost assigned ppong Dec 22, 2012
@ppong
Copy link
Contributor

ppong commented Dec 22, 2012

@changhiskhan @sherb I think the row width is calculated incorrectly. looking into it right now

@changhiskhan
Copy link
Author

Github page example is unscrollable now for sparklines example but if I build it locally it and goto http://localhost:8000/examples/table_with_sparkline/ the table is still scrollable.

@ppong
Copy link
Contributor

ppong commented Dec 24, 2012

@changhiskhan It shouldn't be scrollable horizontally, but it should be scrollable vertically. What browser and version are you using? I could take a look at it.

@ppong ppong reopened this Dec 24, 2012
@changhiskhan
Copy link
Author

Actually, I rebuilt it again and it's working fine now. Not sure what happened as I also rebuilt before I checked last time. Sorry for the mix-up!

@ppong
Copy link
Contributor

ppong commented Dec 24, 2012

@changhiskhan perhaps your browser cached the old javascript file.

@ppong ppong closed this as completed Dec 24, 2012
@changhiskhan
Copy link
Author

Must be the case. Thanks again!
On Dec 24, 2012 5:32 PM, "Peter" notifications@github.com wrote:

@changhiskhan https://github.com/changhiskhan perhaps your browser
cached the old javascript file.


Reply to this email directly or view it on GitHubhttps://github.com//issues/8#issuecomment-11666740.

Gaurav0 pushed a commit to Gaurav0/ember-table that referenced this issue Oct 13, 2015
…erty-in-ember-table

remove unused property in ember table.
billy-addepar added a commit that referenced this issue Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants