-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scrollable header row #8
Comments
For me the sparkline example does seem broken, but in a different way than @changhiskhan describes. It shouldn't even let you scroll horizontally as the table fits in the screen and the others that fit do not. If you resize the sparkline so that all the columns do not fit in the table viewport than it will scroll correctly. |
In the sparklines example, if I resize the the browser so that the table doesn't fit all the columns then the header row scrolling works as expected. |
@changhiskhan @sherb I think the row width is calculated incorrectly. looking into it right now |
Github page example is unscrollable now for sparklines example but if I build it locally it and goto http://localhost:8000/examples/table_with_sparkline/ the table is still scrollable. |
@changhiskhan It shouldn't be scrollable horizontally, but it should be scrollable vertically. What browser and version are you using? I could take a look at it. |
Actually, I rebuilt it again and it's working fine now. Not sure what happened as I also rebuilt before I checked last time. Sorry for the mix-up! |
@changhiskhan perhaps your browser cached the old javascript file. |
Must be the case. Thanks again!
|
…erty-in-ember-table remove unused property in ember table.
I noticed that the headers in the tree table example scrolls with the data (left and right) but the other examples with a fixed column does not (D3 sparkline example).
I tried to read through the code in the examples but couldn't figure it out.
Thanks!
The text was updated successfully, but these errors were encountered: