Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Filter Disable/Enable Issue #1033

Open
4 tasks
ahpourani opened this issue Nov 6, 2024 · 3 comments
Open
4 tasks

General Filter Disable/Enable Issue #1033

ahpourani opened this issue Nov 6, 2024 · 3 comments

Comments

@ahpourani
Copy link

ahpourani commented Nov 6, 2024

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I made sure all content blockers are enabled in Safari settings
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

1.11.20

Environment

- OS:Sequia 15.1
- Safari version: 18.1

What filters do you have enabled?

EasyList

Issue Details

Steps to reproduce:
If I disable the general content blocker, it should be removed from Safari’s directional blocking settings. However, when I try to reenable it in Safari’s directional blocking settings, there’s no general content blocker, and it won’t block ads anymore. Restarting Safari or the operating system doesn’t resolve this issue. I need to remove and reinstall AdGuard several times to see when it will reappear.

Expected Behavior

No response

Actual Behavior

Sometimes, users want to uncheck the general adblock option for performance reasons.

Screenshots

Screenshot 1:
Screenshot 2024-11-06 at 9 16 12 PM Screenshot 2024-11-06 at 9 16 23 PM

Additional Information

No response

@windwak3r
Copy link

@ahpourani, hello! Please explain step by step how to reproduce the problem.

@ahpourani
Copy link
Author

ahpourani commented Nov 8, 2024

I’ll try to describe the problem step by step:

  1. I’ll install AdGuard for Safari (from the App Store or GitHub).
  2. I’ll open the AdGuard app and want to activate Safari-related extensions.
  3. I’ll activate the Safari-related extensions.
  4. Then, I’ll uncheck the unwanted list except for the general filter list.

At this point, everything functions as intended.

  1. Now, let’s say I want to uncheck the “General Extension” option from my Safari for performance reasons. It will delete the “Content Filter” option from my Safari’s directory: ~/Library/Containers/com.apple.Safari/Data/Library/WebKit/ContentExtensions.

  2. Next, I want to reenable it from the Safari extensions settings file. However, it doesn’t rewrite the directory again, and it doesn’t show up. This issue is specific to the “General Filter” list; other lists work as expected.

  3. If I want to make the “General Filter” list available again, I need to reinstall AdGuard several times to see when it shows up the content blocker list in my safari directory.

I hope this clarifies the issue for you.

@ahpourani
Copy link
Author

ahpourani commented Nov 12, 2024

It seems all the filter lists have this issue

Screenshot 2024-11-12 at 10 39 38 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants