Remove Docker image health check

[agneevX]

I initially suggested the addition of health checks to the Docker image, but as it has become very apparent with the rapid influx of new issues, that there are many edge cases that have arisen with the check.

The check also serves no real purpose... a user running an application like autoheal can put the app in a restart loop.

Further, the health check feature consumes CPU very frequently and makes excessive writes to I/O.

moby/moby#39102

It would be wise to remove the check and revert changes made to the Dockerfile entrypoint/cmd options.

[ainar-g]

Besides those, removing the healthcheck would allow us to remove the ENTRYPOINT directive, which seems to be the culprit in many docker-compose and podman issues.

I'll pin this discussion for some time, and if there aren't any objections, we'll probably remove it.

[ainar-g]

As of Edge version v0.108.0-a.603+f7dd8325, the healthcheck is removed.

[up2you1]

im using AGH in Portainer and tried edge, beta and latest channels and seem to be getting this:

OCI runtime exec failed: exec failed: unable to start container process: exec: "/opt/adguardhome/scripts/healthcheck.sh": stat /opt/adguardhome/scripts/healthcheck.sh: no such file or directory: unknown

portainer shows AGH to be unhealthy, but DNS still working ok, any harm to leave it like it is? or how do i fix?

[ainar-g]

@up2you1, please read this note in the Release notes

NOTE: Some Docker tools may cache ENTRYPOINT sections, so some users may be required to backup their configuration, stop the container, purge the old image, and reload it from scratch.

Apparently, HEALTHCHECK sections are also cached. You need to backup your configuration and recreate the container from a new image.

[up2you1]

perfect, thanks!

[peytonjol]

worked. Thanks !

[Turbine1313]

Will a recrate or duplicate container will work as well ?
Because I still get that error.
Thanks

[soundneedle]

Will a recrate or duplicate container will work as well ?

Because I still get that error.

Thanks

I tried duplicating and still getting the error