Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the DNS blocking limitations and issues #1433

Closed
jerrac opened this issue Feb 26, 2020 · 10 comments
Closed

Document the DNS blocking limitations and issues #1433

jerrac opened this issue Feb 26, 2020 · 10 comments

Comments

@jerrac
Copy link

jerrac commented Feb 26, 2020

Problem Description

YouTube ads are not blocked.

When viewing YT videos via the Roku app, or Firefox without any adblocking extension enabled, the preroll ads always play.

Searching the issue queue pulled up multiple comments stating that DNS blocking does not work for YouTube ads. This is confusing because I have seen PiHole successfully block YouTube ads. LinusTechTips actually did a YouTube video doing so.

Proposed Solution

Please document if AdGuardHome can, or cannot, block YouTube ads in the README, or somewhere new users can find quickly.

Additional Information

@ghost
Copy link

ghost commented Feb 26, 2020

because I have seen PiHole successfully block YouTube ads. LinusTechTips actually did a YouTube video doing so.

#1325

@ameshkov
Copy link
Member

This is confusing because I have seen PiHole successfully block YouTube ads. LinusTechTips actually did a YouTube video doing so.

Could you please link this video?

@mmotti
Copy link

mmotti commented Feb 27, 2020

Pihole can't block YouTube ads. No DNS based, or even regex capable adblocker can.

It is impossible without modified YouTube apps or browser extensions.

As for the video, I remember watching this myself. Just because they didn't hit an ad in testing, doesn't mean that it successfully blocks YouTube ads.

The videos and ads are served from the same domains and, as I understand it, these swap and change between showing ads and video content. People have even tried and failed to create regexps on domains thought to serve ads but it just ends up blocking the videos too.

@jerrac
Copy link
Author

jerrac commented Feb 27, 2020

The video in question: https://www.youtube.com/watch?v=KBXTnrD_Zs4

Just rewatched it, they did mention that blocking YouTube ads was iffy, and they didn't see it happen in the PiHole logs. I hadn't seen the video since it came out, so I didn't remember that. :)

Anyway, I still think it would be a good thing to document that blocking YouTube ads isn't easy/possible somewhere people will find when they start looking. A version @mmotti 's comment in the readme or a wiki page would be awesome.

Thanks!

@ghost
Copy link

ghost commented Feb 27, 2020

Well, If certain youtube ads possible to block using browser extension then adguard home will be capable to do it in future

@ameshkov ameshkov changed the title Please document YouTube Adblocking Support in README Document the DNS blocking limitations and issues Feb 27, 2020
@ameshkov ameshkov added this to the v0.103 milestone Feb 27, 2020
@ameshkov
Copy link
Member

Well, I think documenting known issues and limitations is a good thing anyway.

Besides Youtube, what do you think makes sense to add?

@ghost
Copy link

ghost commented Feb 28, 2020

Facebook and Instagram sponsored posts and stories in app, and any TV apps that include advertising will be a hit-and-miss, such as Twitch, free-to-air catch up or on demand apps.

Essentially, any advertising that shares a domain with content will be a known issue and limitation.

@jerrac
Copy link
Author

jerrac commented Apr 15, 2020

Essentially, any advertising that shares a domain with content will be a known issue and limitation.

Something like this, plus a couple examples, would cover it.

@stale
Copy link

stale bot commented Jun 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 14, 2020
@stale stale bot closed this as completed Jun 21, 2020
@ameshkov
Copy link
Member

Argh, bad bot

@ameshkov ameshkov reopened this Jun 21, 2020
@stale stale bot removed the wontfix label Jun 21, 2020
@ameshkov ameshkov self-assigned this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants