Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Users to Choose Date/Time Format #1498

Open
3 tasks done
Ultrabenosaurus opened this issue Mar 21, 2020 · 9 comments
Open
3 tasks done

Allow Users to Choose Date/Time Format #1498

Ultrabenosaurus opened this issue Mar 21, 2020 · 9 comments

Comments

@Ultrabenosaurus
Copy link

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Problem Description

AdGuard Home shows dates as 3/21/2020 but I live in the UK so this format doesn't make sense to me, and I have to look twice at a lot of dates - there is no 21st month! Most people in the UK would expect 21/03/2020 - note the leading zero on single-digit values. However, I personally prefer a format like 2020-03-21. There may also be people who prefer something like 21 Mar, 2020.

Similarly for time, I would like to see seconds on all times in the AdGuard Home UI but I can see why others don't care about seconds. However, right now in the Query Log, AGH show seconds for items on the current day but not for items on previous days. Being able to choose this would be nice.

Query Log seconds

Proposed Solution

Add an option in General Settings where users can choose the date format they prefer. Possibly also have a "Custom" option where users can specify the exact format they want, e.g. yyyy-mm-dd hh:mm:ss or similar.

@lancelot-moon
Copy link

lancelot-moon commented Mar 22, 2020

For your 1st point:
TBH, month/date/year is weird in English.
At school, our English teacher taught us "date month, year".
But you can see month/date/year everywhere in AG products.
ex:
https://crowdin.com/translate/adguard-applications/17492/en-zhtw#3858028
last updated 8/5/2019 at 3:35 PM
Is it August or May?

Screenshot:

image


I think it's more correct if last updated {1} at {2} -> last updated at {2} on {1}.
But AG team like to use month/date/year at hour:minute in English.

Fortunately, time format in most AG products is localized.
The time format may be only problematic to English users.
yyyy-mm-dd hh:mm:ss is much better than mm/dd/yyyy hh:mm:ss!

For your 2nd point:
In the past, we requested localized and detailed time format, including sec.
#624
But sec is ignored in v0.101.0.

Screenshot:

image


@ghost
Copy link

ghost commented Mar 22, 2020

@deanishe
Copy link

TBH, month/date/year is weird in English.

Not just in English. It's a format that's hardly used except by Americans.

Of all the commonly-used formats, m/d/y is basically the worst possible choice. It's ambiguous and easily confused with the far more common d/m/y.

I'd suggest either using YYYY-MM-DD or writing the month as a word to remove the ambiguity (e.g. "1 Jun" or "Jun 1").

@ameshkov ameshkov added the UI label Jun 22, 2020
@ameshkov ameshkov added this to the v0.105 milestone Jun 22, 2020
@Quijib0
Copy link

Quijib0 commented Oct 2, 2020

So I notice in 0.103.3 that basically the format got switched the other way. Really would be nice for those of us that don't live in Europe to have a choice to have it in the other format: mm/dd/yyyy. I wouldn't complain about yyyy-mm-dd though, at least the day is in the right order (for my eyes).

If it is localized, then it's not working on my end. Router is using correct local format.

@deanishe
Copy link

deanishe commented Oct 2, 2020

Really would be nice for those of us that don't live in Europe

*that live in the US

@ameshkov
Copy link
Member

ameshkov commented Oct 5, 2020

Should be a little better in v0.104, I am not sure why we the code of formatDateTime was that confusing, now it's rather simple - we always use browser locale to format the date: 8856dd6

@ainar-g ainar-g changed the title [Feature Request] Allow Users to Choose Date/Time Format Allow Users to Choose Date/Time Format Jan 27, 2022
@sourpatched
Copy link

Is this option going to be added to next update?

I've spent hours trying to fix this, thinking if was my OS or browser.

@lutfor-diu
Copy link

any update about this feature request :)

@mixmastamyk
Copy link

I'd like ISO 8601 dates. In my query log, why does the time go big-to-small but the date goes small-to-big? Kinda silly, don't you think. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants