Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - MAC address to 'Friendly name' mapping table #438

Closed
AnthonyBe opened this issue Oct 27, 2018 · 33 comments
Closed

Feature Request - MAC address to 'Friendly name' mapping table #438

AnthonyBe opened this issue Oct 27, 2018 · 33 comments
Assignees
Milestone

Comments

@AnthonyBe
Copy link

Looking at IP addresses in the Top Clients table and Query Log means I still have to know what device has that IP address to take an action, or at least understand the correlation.

This request is to include a MAC Adress to 'friendly name' mapping table so that in the above scenarios, instead of showing an IP address, if a friendly name exists in the mapping table, then it will show the user-defined friendly name associated with the IP address.

This could initially be a simple manually editable txt or xml file but ultimately should be included in the UI so that users can see the devices already known by AGH and assign a friendly name to them, as well as add MAC address and friendly name for new/unknown devices.

@jtenniswood
Copy link

Totally agree with this need, I have been using pihole in docker, using --add-host="devicename.10:192.168.x.x", but this system doesn't seem to use the host file to map ip's to names, which is a real shame, as it limits the usability of the information coming back.

@ameshkov
Copy link
Member

ameshkov commented Oct 29, 2018

First of all, we need to figure out the MAC address corresponding to the IP address.

There are several options.

  1. Automatic: in case if AG Home operates as a DHCP server (Act as DHCP server #423), this is quite easy;
  2. Automatic: inspecting ARP cache (arp -a);
  3. Semi-automatic: using hostnames
  4. Manual: Allow configuring mapping in the UI;

Second, we need to have a separate settings screen specifically for inspecting known clients & editing their properties.

@jtenniswood
Copy link

As a quick win, it would be great if the system could use the hostnames to give IP's usable names.
That's enough for me.

@ameshkov
Copy link
Member

Added hostnames to the list of options, thank you!

@AnthonyBe
Copy link
Author

Given the number of DHCP IP devices on my network, I really would prefer not to rely on hostname mapping which is why my initial req was MAC-to-IP. While most of my devices likely retain the same IP allocated by my DHCP server, I do have some devices that are less frequently on my network and thus could be allocated a different IP address from time to time.

I'm reluctant to use DHCP capability in AGH unless it is full-featured. E.g. I don't even use my router's built-in DHCP server because it only lets you assign the most basic features, IP and gateway, so I use the DHCP Server on a Windows Server 2012 R2 box.

Inspecting ARP cache would be perfectly fine for me.

@ameshkov
Copy link
Member

ameshkov commented Nov 5, 2018

@AnthonyBe we're going to implement all 4 options, not just one of them.

@ameshkov ameshkov added this to the v0.92 milestone Nov 5, 2018
@AnthonyBe
Copy link
Author

Thanks @ameshkov , glad to hear that. I wasn't sure if it was going to be a staggered implementation or not so I just wanted to provide perspective from a keen user! :)

@rashidjehangir
Copy link

Hi Guys, any progress on this? It is very difficult to figure out IP addresses of multiple devices. @ameshkov

@i1u5
Copy link

i1u5 commented Jan 7, 2019

@rashidjehangir it will be released with the version 0.92 ( https://github.com/AdguardTeam/AdGuardHome/milestone/4 ), and it's close assuming by the replies on each issue although there is still no ETA.

@rashidjehangir
Copy link

@rashidjehangir it will be released with the version 0.92 ( https://github.com/AdguardTeam/AdGuardHome/milestone/4 ), and it's close assuming by the replies on each issue although there is still no ETA.

Thanks - will be a really user friendly feature. Right now its a nightmare to reference IP's

@ameshkov
Copy link
Member

ameshkov commented Jan 9, 2019

Guys, no ETA on this yet. I've preliminarily assigned it to milestone 0.93 to emphasize that improving this part of AG Home is one of the most important feature requests, but most likely I'll divide it into several tasks or even create a new milestone dedicated to "Client management". You see, it's not just about assigning names. In the future, AGH should let you have different (to some extent) client-specific configurations.

@ameshkov
Copy link
Member

First part of this issue will be ready in v0.94 -- using hosts files: #637

But that's not the end, we'll extend it later in v0.95.

@ameshkov ameshkov modified the milestones: v0.94, v0.95 Mar 11, 2019
@rashidjehangir
Copy link

Hi Guys, I have added the IP addresses but Adguard Homes says - The system cannot find the file specified. Is there a format that I am entering wrong? I have used a space after the IP Address - for example 192.168.1.1 MyPC

@ameshkov
Copy link
Member

@rashidjehangir could you please explain where exactly have you added them? Is it the local hosts file?

@rashidjehangir
Copy link

Yes- local hosts file as per the instructions

@ameshkov
Copy link
Member

Have you restarted AGH after doing that?

The system cannot find the file specified

Where does this error come from? Can you please share the AGH log?

@rashidjehangir
Copy link

Sure. Pardon my ignorance but how do I share the log?

@rashidjehangir
Copy link

Yes. I have restarted. Now the error is not showing up but still cant see the friendly names

@ameshkov
Copy link
Member

ameshkov commented Mar 29, 2019

@rashidjehangir you know, there's a simpler solution, open http://AGH_ADDRESS/control/clients URL and check if your IP address is listed there

@rashidjehangir
Copy link

@ameshkov tried - says "site cant be reached" in browser

@ameshkov
Copy link
Member

@rashidjehangir check that you didn't forget the port

@rashidjehangir
Copy link

@ameshkov did it - can see the Adguard interface but its blank

@ameshkov ameshkov modified the milestones: v0.95, v0.96 Mar 29, 2019
@ameshkov
Copy link
Member

@rashidjehangir what OS are you on? What's the exact path to the hosts file?

@rashidjehangir
Copy link

@ameshkov Using Windows 10 - path is C:\Windows\System32\drivers\etc

@ameshkov
Copy link
Member

ameshkov commented Apr 1, 2019

@rashidjehangir got it, thank you! Is it 32-bit or 64-bit Windows?

@szolin could you please check it on a Windows machine?

@rashidjehangir
Copy link

@ameshkov 64-bit Windows. Another question - do I use a space or a TAB between IP Address and friendly name? I have tried both unsuccessfully.

@ameshkov
Copy link
Member

ameshkov commented Apr 1, 2019

Another question - do I use a space or a TAB between IP Address and friendly name?

Both are okay, It shouldn't matter

@Orava2
Copy link

Orava2 commented Apr 13, 2019

IP -> MAC address -> Vendor name, would be enough for me. This is what many routers do.
In Windows:
https://docs.microsoft.com/en-us/windows/desktop/api/iphlpapi/nf-iphlpapi-sendarp
http://standards-oui.ieee.org/oui.txt

Network view tab would be handy. Like in Fing app.
Maybe just like
nmap -PR 192.168.1.1/24 -sn
and for extra info
nmap -v -Pn -A 192.168.1.50

@szolin
Copy link
Contributor

szolin commented Jun 3, 2019

  1. Automatic: in case if AG Home operates as a DHCP server (Act as DHCP server #423), this is quite easy;
  2. Automatic: inspecting ARP cache (arp -a);
  3. Semi-automatic: using hostnames
  4. Manual: Allow configuring mapping in the UI;

Second, we need to have a separate settings screen specifically for inspecting known clients & editing their properties.

p.1, p.4 are done: we can set name for a specific MAC in UI and we translate MAC to IP, IP to name when our DHCP server is running.
p.2 & p.3 are still to be considered.

@szolin szolin modified the milestones: v0.96, v0.97 Jun 3, 2019
@AnthonyBe
Copy link
Author

So I basically have to use AGH DHCP server. Not happy with that to be honest.

@ameshkov
Copy link
Member

ameshkov commented Jun 4, 2019

That's why we're not closing this issue yet:)

@ameshkov ameshkov modified the milestones: v0.97, v0.98 Jul 2, 2019
@ameshkov
Copy link
Member

ameshkov commented Aug 5, 2019

  1. Automatic: inspecting ARP cache (arp -a);

Done: #826

@ameshkov ameshkov closed this as completed Aug 5, 2019
@siewers
Copy link

siewers commented Dec 1, 2021

Sorry for necroposting, but as far as I understand, this issue was about using the possiblity to have AdGuard Home translate MAC addresses into friendly names and not requiring the use of the AdGuard Home DHCP server.
I can't seem to get that to work, and the wiki also states that in order to resolve a client by MAC, you have to use the DHCP server, which is not possible in my case (using an AmplifyHD router).

I just found #961 which seems to cover this exact issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants