Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML, /#logs - issue #465

Closed
happyhater opened this issue Nov 28, 2018 · 8 comments
Closed

YAML, /#logs - issue #465

happyhater opened this issue Nov 28, 2018 · 8 comments

Comments

@happyhater
Copy link

2018/11/28 22:22:17 Couldn't save YAML config: rename adguard.yaml.tmp adguard.yaml: no such file or directory
2018/11/28 22:22:17 rename adguard.yaml.tmp adguard.yaml: no such file or directory

and issue in /#logs when you load external filters and block them, you cannot load anymore this page:
TypeError: undefined is not an object (evaluating 'l[d].name')

@happyhater happyhater changed the title YAML, Client issue YAML, /#logs - issue Nov 28, 2018
@happyhater
Copy link
Author

also:

npm WARN deprecated browserslist@1.7.7: Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools.
npm WARN deprecated circular-json@0.3.3: CircularJSON is in maintenance only, flatted is its successor.

@ameshkov
Copy link
Member

and issue in /#logs when you load external filters and block them, you cannot load anymore this page:

Could you please provide some exact steps to reproduce this?

@happyhater
Copy link
Author

happyhater commented Nov 29, 2018

Filters: []filter{
	{ID: 1, Enabled: true, URL: "https://adguardteam.github.io/AdGuardSDNSFilter/Filters/filter.txt", Name: "AdGuard Simplified Domain Names filter"},
	{ID: 2, Enabled: false, URL: "https://adaway.org/hosts.txt", Name: "AdAway"},
	{ID: 3, Enabled: false, URL: "https://hosts-file.net/ad_servers.txt", Name: "hpHosts - Ad and Tracking servers only"},
	{ID: 4, Enabled: false, URL: "http://www.malwaredomainlist.com/hostslist/hosts.txt", Name: "MalwareDomainList.com Hosts List"},
},

Example from first link with mbzl-pro.xyz:
host mbzl-pro.xyz 127.0.0.1
result:
blocked

after refresh the page /#logs
and you got this Error in console and the page is blocked in blank:
TypeError: undefined is not an object (evaluating 'l[d].name')

@hmage
Copy link
Contributor

hmage commented Nov 29, 2018

How are you launching adguard home?

If systemd, could you please provide systemd logs? journalctl -a > log and attach the log file to the issue.

@hmage
Copy link
Contributor

hmage commented Nov 29, 2018

It was likely a race condition, try building from source newest master and see if the problem still remains.

@hmage
Copy link
Contributor

hmage commented Nov 29, 2018

Yep, managed to reproduce the issue. The latest commit 45ae984 fixes the issue.

@hmage hmage closed this as completed Nov 29, 2018
@happyhater
Copy link
Author

Bug still alive.

@happyhater
Copy link
Author

[Error] TypeError: undefined is not an object (evaluating 'l[d].name')
Cell — bundle.7bca668e8a003e830e80.js:48758
(anonymous function) — bundle.7bca668e8a003e830e80.js:3403
map
t — bundle.7bca668e8a003e830e80.js:3373
map
nt — bundle.7bca668e8a003e830e80.js:3349
ca — bundle.7bca668e8a003e830e80.js:14345
Ga — bundle.7bca668e8a003e830e80.js:15200
Va — bundle.7bca668e8a003e830e80.js:15223:161
Ci — bundle.7bca668e8a003e830e80.js:15476
Ii — bundle.7bca668e8a003e830e80.js:15462
ki — bundle.7bca668e8a003e830e80.js:15404
Qa — bundle.7bca668e8a003e830e80.js:15362
enqueueSetState — bundle.7bca668e8a003e830e80.js:13995
setState — bundle.7bca668e8a003e830e80.js:11632
onStateChange — bundle.7bca668e8a003e830e80.js:6710
[native code]
notify — bundle.7bca668e8a003e830e80.js:16602
notifyNestedSubs — bundle.7bca668e8a003e830e80.js:16579:174
[native code]
onStateChange — bundle.7bca668e8a003e830e80.js:6710
[native code]
g — bundle.7bca668e8a003e830e80.js:4514
(anonymous function) — bundle.7bca668e8a003e830e80.js:1383:87
w — bundle.7bca668e8a003e830e80.js:17168
(anonymous function) — bundle.7bca668e8a003e830e80.js:17150
o — bundle.7bca668e8a003e830e80.js:3583
(anonymous function) — bundle.7bca668e8a003e830e80.js:3590
promiseReactionJob

ya (bundle.7bca668e8a003e830e80.js:45:66403)
callback (bundle.7bca668e8a003e830e80.js:45:70721)
uo (bundle.7bca668e8a003e830e80.js:45:46054)
so (bundle.7bca668e8a003e830e80.js:45:45854)
Pi (bundle.7bca668e8a003e830e80.js:45:90187)
Ci (bundle.7bca668e8a003e830e80.js:45:85577)
Ii (bundle.7bca668e8a003e830e80.js:45:84922)
ki (bundle.7bca668e8a003e830e80.js:45:83943)
Qa (bundle.7bca668e8a003e830e80.js:45:82846)
enqueueSetState (bundle.7bca668e8a003e830e80.js:45:47683)
setState (bundle.7bca668e8a003e830e80.js:37:1920)
onStateChange (bundle.7bca668e8a003e830e80.js:17:4470)
(anonymous function)
notify (bundle.7bca668e8a003e830e80.js:61:2705)
notifyNestedSubs (bundle.7bca668e8a003e830e80.js:61:2347)
(anonymous function)
onStateChange (bundle.7bca668e8a003e830e80.js:17:4496)
(anonymous function)
g (bundle.7bca668e8a003e830e80.js:12:53927)
(anonymous function) (bundle.7bca668e8a003e830e80.js:1:26062)
w (bundle.7bca668e8a003e830e80.js:61:13429)
(anonymous function) (bundle.7bca668e8a003e830e80.js:61:13214)
o (bundle.7bca668e8a003e830e80.js:12:34016)
(anonymous function) (bundle.7bca668e8a003e830e80.js:12:34113)
promiseReactionJob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants