Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style filter is applied, but scriptlet filter is not in Firefox #2782

Closed
zenstorage opened this issue Apr 12, 2024 · 3 comments
Closed

Style filter is applied, but scriptlet filter is not in Firefox #2782

zenstorage opened this issue Apr 12, 2024 · 3 comments

Comments

@zenstorage
Copy link

zenstorage commented Apr 12, 2024

AdGuard Extension version

4.3.35

Browser version

Chrome 123 / Firefox 124

OS version

Windows 11

What filters do you have enabled?

No filters

What Stealth Mode options do you have enabled?

No response

Issue Details

In these filters:

twitter.com##+js(json-prune-xhr-response, data.user.result.timeline_v2.timeline.instructions.[].entries.[].content.items.[].item.itemContent.tweet_results.result.legacy.possibly_sensitive, , propsToMatch, url:/UserMedia)
twitter.com##+js(rmnt, #text, /./)
twitter.com##div:style(border: 1px solid red !important;)

The style filter is applied in Chrome and FIrefox, but the scriptlet filter is not applied in FIrefox, I have already tried using the Adguard and ABP syntax but it has the same result,I let something go?

Expected Behavior

Scriptlet filter to be applied

Screenshots

All filters working in Chrome:

chrome:

chrome

Only style filter working in Firefox:

firefox:

firefox

Additional Information

No response

@slavaleleka
Copy link
Contributor

rmnt scriptlet should work fine

but json-prune-xhr-response is not available in the extension v4.3.35, it was added in Scriptlets v1.10.25 and available in AdGuard Browser extension v4.3.46

@AdamWr
Copy link
Member

AdamWr commented Apr 12, 2024

I think that the problem is related to - #1733 and any scriptlet/JavaScript rule doesn't work with extension for Firefox on twitter.com, because it's blocked by website's Content Security Policy.

Any chance for prioritizing this task? - #1733

As I recall, similar issue is in AdGuard MV3 version - AdguardTeam/AdGuardMV3#57

@maximtop
Copy link
Contributor

Thanks, @AdamWr

Indeed, it seems like the problem is with the CSP, since scriptlet rules are working in Firefox—take example.org, for example.

Any chance for prioritizing this task? - #1733

I've moved it to v4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@maximtop @AdamWr @adguard-bot @slavaleleka @zenstorage and others