Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The blocking page of AG for Mac is English while system language is Chinese (or Portuguese) locale. #502

Closed
lancelot-moon opened this issue May 26, 2019 · 6 comments

Comments

@lancelot-moon
Copy link

lancelot-moon commented May 26, 2019

@sfionov

May be related to these bugs.
AdguardTeam/AdguardForAndroid#2651
AdguardTeam/CoreLibs#805
I guess maybe it's the same situation in Portuguese.

But I found that the 2 phrases are also in Adguard for Mac / AdGuard for Mac 2.0 on onesky.
#48597459
This web page at (var.Host) has been reported as a malware page and has been blocked based on your security preferences.

#48597461
This web page at (var.Host) has been reported as a phishing page and has been blocked based on your security preferences.

Does AG for Mac not use the phrases about blocking pages in Misc / Misc on onesky?

Test the domain:
https://ilo134ulih.com/

Screenshot:

image


Hope the blocking page can be Traditional Chinese (zh-TW) while system language is Traditional Chinese.
Thanks.

@ameshkov
Copy link
Member

Blocking pages are managed by CoreLibs, and AG for Mac the previous version of CoreLibs where these issues aren't solved yet. You should simply wait a little bit until the newer version of CoreLibs is shipped.

@lancelot-moon
Copy link
Author

lancelot-moon commented May 26, 2019

I supposed that this should be solved in #491.

The issue was fixed in AG for Windows/Android (CoreLibs v1.3.325).

The CoreLibs is already v1.3.335 in AG for Mac v2.0.2 beta, but the blocking page is still English.

Screenshot:

image


@ameshkov
Copy link
Member

Issue moved to AdguardTeam/CoreLibs #917 via ZenHub

@ameshkov
Copy link
Member

@maximtop might be the same issue as #503 (comment)

@lancelot-moon
Copy link
Author

lancelot-moon commented May 29, 2019

In v2.0.3 beta, the blocking page is still an English page.
It should be Traditional Chinese in Traditional Chinese interface.

Test the domain:
https://ilo134ulih.com/

Screenshot:

image


@Stillness-2, you didn't check by yourself.

@lancelot-moon
Copy link
Author

lancelot-moon commented May 31, 2019

@Stillness-2

Why is the issue fixed in nightly but NOT fixed in v2.0.4 Release?

The same wrong things as v2.0.3 beta.
The blocking page is English.

Update:
#503 (comment)
In the past, AG for Mac on GitHub was wrong build.

This was fixed in normal v2.0.4 Release.

@zzebrum zzebrum closed this as completed Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants