Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules with insensitive attribute don't work #104

Closed
AdamWr opened this issue Mar 16, 2020 · 3 comments
Closed

Rules with insensitive attribute don't work #104

AdamWr opened this issue Mar 16, 2020 · 3 comments
Assignees
@slavaleleka
Labels
bug P2: Medium Resolution: Fixed Status: Closed
Milestone
2.0

Comments

@AdamWr
Copy link
Member

AdamWr commented Mar 16, 2020 •
edited
Loading

It seems that rules with insensitive attribute don't work.
For example:
adguard.com#?#body:has(div[class="page" i])
or
adguard.com#?#div[class="page" i]

Screenshot

image

Rule like this:
adguard.com##body div[class="page" i]
or
adguard.com##div[class="page" i]
works fine.

Screenshot

image
@AdamWr AdamWr changed the title Rules with insensitive attribute doesn't work Rules with insensitive attribute don't work Mar 16, 2020
@ameshkov ameshkov added this to the 1.3 milestone Mar 16, 2020
@ameshkov ameshkov modified the milestones: 1.3, 2.0 May 18, 2020
@slavaleleka
Copy link
Contributor

Sizzle does not support case-insensitive attribute so we can not fix it with ease now

@slavaleleka
Copy link
Contributor

merged into #110

@ameshkov ameshkov mentioned this issue Aug 11, 2020
Closed
6 tasks
@AdamWr AdamWr mentioned this issue Dec 2, 2021
Closed
@ameshkov
Copy link
Member

ameshkov commented Dec 3, 2021

Let’s reopen it and implement at least a temporary solution. At least we could discard these rules.

@ameshkov ameshkov reopened this Dec 3, 2021
@adguard-bot adguard-bot reopened this Dec 5, 2021
@AdamWr AdamWr mentioned this issue Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
bug P2: Medium Resolution: Fixed Status: Closed
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@ameshkov @AdamWr @adguard-bot @slavaleleka