Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print more details when build failed because of invalid directives #213

Closed
Alex-302 opened this issue Mar 26, 2024 · 1 comment
Closed

Print more details when build failed because of invalid directives #213

Alex-302 opened this issue Mar 26, 2024 · 1 comment
Assignees
@jellizaveta
Labels
Priority: P4 Resolution: Fixed Status: Closed

Comments

@Alex-302
Copy link
Member

Issue details

At the moment we see only one problematic line, if something went wrong

image

If a filter compiled from dozens of files, it is hard to find where the problem exactly.
For example, Dandelion Sprout's Annoyances List has more than 25 files, including nested include directives.

Proposed solution

  • Print a path on the file with a problem
  • Print a line number

Alternative

If validation applied to a merged file - print 5 next and previous lines by which it will be possible to find the desired file or file line.
@105th
Copy link
Member

105th commented Mar 26, 2024

This can be achieved by updating filters-downloader to the second version - it contains more informative logs.

@adguard-bot adguard-bot assigned jellizaveta and unassigned maximtop Nov 28, 2024
slavaleleka referenced this issue Dec 11, 2024
@jellizaveta
AG-31412 Update filters-downloader to 2.2.4
674c946 
Squashed commit of the following:

commit 05c4a51af19cccaf985d6cdb0b58446bf1aef580
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Dec 9 18:20:20 2024 +0300

    Applied suggestion

commit e11c607258e889a0d06434662299af3f5de1ee39
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Dec 9 18:18:23 2024 +0300

    Applied suggestion

commit d96c34046ff76d4d2468f2eb790de3edd6caf0ed
Author: jellizaveta <e.egorova@adguard.com>
Date:   Mon Dec 9 16:39:50 2024 +0300

    update changelog

commit 26a01caf4b03ea19f71f36ddb65f43c43e1599c9
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Dec 9 16:37:43 2024 +0300

    Applied suggestion

commit 9e07ebecfce5a3db3c1fd05e5016fb20ae1a5a68
Author: jellizaveta <e.egorova@adguard.com>
Date:   Mon Dec 9 14:49:03 2024 +0300

    AG-31412 Update filters-downloader to 2.2.4
slavaleleka referenced this issue in AdguardTeam/FiltersDownloader Dec 11, 2024
@jellizaveta
AG-31412 Improve error message during include directives resolving.
2db4570 
Squashed commit of the following:

commit 9708d21
Author: jellizaveta <e.egorova@adguard.com>
Date:   Fri Dec 6 14:11:08 2024 +0300

    update changelog

commit df3b5b0
Author: jellizaveta <e.egorova@adguard.com>
Date:   Fri Dec 6 13:42:38 2024 +0300

    update CHANGELOG

commit 33ccd0c
Merge: 52af3a2 6fd1af1
Author: jellizaveta <e.egorova@adguard.com>
Date:   Wed Dec 4 19:37:20 2024 +0300

    conflicts

commit 52af3a2
Author: jellizaveta <e.egorova@adguard.com>
Date:   Wed Dec 4 19:36:34 2024 +0300

    update names and context extraction, create a separate file for logger functions

commit 6fd1af1
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Dec 4 13:37:05 2024 +0300

    src/filters-downloader-creator.ts edited online with Bitbucket

commit ddd9ac0
Author: jellizaveta <e.egorova@adguard.com>
Date:   Wed Dec 4 13:03:31 2024 +0300

    fix error logging

commit 47fafe8
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Dec 4 12:58:13 2024 +0300

    src/filters-downloader-creator.ts edited online with Bitbucket

commit bdb6e7c
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Dec 4 12:58:07 2024 +0300

    src/filters-downloader-creator.ts edited online with Bitbucket

commit 9a587c2
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Dec 4 12:57:46 2024 +0300

    src/filters-downloader-creator.ts edited online with Bitbucket

commit 514bfe6
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Dec 4 12:57:28 2024 +0300

    src/filters-downloader-creator.ts edited online with Bitbucket

commit 8b5f0cc
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Dec 3 19:55:44 2024 +0300

    revert Qunit tests

commit f80bb02
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Dec 3 19:53:36 2024 +0300

    added error message when possible

commit dc7b00a
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Dec 3 19:10:39 2024 +0300

    error handling

commit 9ab4725
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Dec 3 18:20:36 2024 +0300

    __tests__/filters-downloader.test.ts edited online with Bitbucket

commit b3a10e9
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Dec 3 18:05:26 2024 +0300

    fix error messages

commit 3c808c1
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Dec 3 17:49:00 2024 +0300

    Fix cd '/Users/elizavetaegorova/Documents/filters-downloader'

commit eae8b8e
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Dec 3 17:34:46 2024 +0300

    update tests

commit 569ff8f
Author: jellizaveta <e.egorova@adguard.com>
Date:   Mon Dec 2 21:03:49 2024 +0300

    fix comment

commit 073c59b
Merge: 5405295 c2cb8ab
Author: jellizaveta <e.egorova@adguard.com>
Date:   Mon Dec 2 21:03:04 2024 +0300

    Merge branch 'fix/AG-31412' of ssh://bit.int.agrd.dev:7999/extensions/filters-downloader into fix/AG-31412

commit 5405295
Author: jellizaveta <e.egorova@adguard.com>
Date:   Mon Dec 2 21:02:44 2024 +0300

    update createErrorMessage function

... and 11 more commits
@slavaleleka slavaleleka mentioned this issue Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jellizaveta jellizaveta

Labels
Priority: P4 Resolution: Fixed Status: Closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Alex-302 @105th @maximtop @adguard-bot @jellizaveta