Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Futa Filter (for AG and AG Home) #430

Closed
Yuki2718 opened this issue Mar 8, 2021 · 15 comments
Closed

Add Futa Filter (for AG and AG Home) #430

Yuki2718 opened this issue Mar 8, 2021 · 15 comments
Assignees

Comments

@Yuki2718
Copy link
Contributor

Yuki2718 commented Mar 8, 2021

https://github.com/FutaGuard/FutaFilter
The lists are overall good and worth adding.

@ameshkov
Copy link
Member

ameshkov commented Mar 8, 2021

  1. I see that https://filter.futa.gg/filter.txt uses JS rules which we generally don't allow in third-party lists (unless they are installed as custom trusted lists). @tasi788 can these JS rules be converted to scriptlets or to other rule types?
  2. Could you please come up with an English name and description that we can use?
  3. I generally like the $removeparam list and I think it'd be nice to have it in the "Privacy" group, but in order to do that, there should be a homepage/repo with an English description. The list seems to be "global" enough to not be placed in the regional lists. This is up to you, of course.

@tasi788
Copy link

tasi788 commented Mar 9, 2021

  1. we've tried using scriptlet instead, check here.
    FutaGuard/LowTechFilter@6592053#diff-2b332613793173c8760f7c21faa3b9e3543b3a2329b1a51108993345ded05dbf
    thanks @bestpika
  2. see below.
  3. maybe I can adding a new wiki page in repo, or just adding README.en.md instead. If this is ok. (or we can add filter description in site.futa.gg in future)

@tasi788
Copy link

tasi788 commented Mar 9, 2021

Title: FutaFilter List
URL: https://filter.futa.gg/filter.txt
Description: an advertisement blocking list specialized for Taiwanese users.
Homepage: https://github.com/FutaGuard/FutaFilter/blob/master/README.en.md

Title: FutaFilter URL Privacy Guardner List
URL: https://filter.futa.gg/removeparam.txt
Description: Now the tracker is proliferating and can be seen everywhere. This list designed to against URL tracks, protect users privacy.
Homepage: https://github.com/FutaGuard/FutaFilter/blob/master/README.en.md

@ameshkov
Copy link
Member

Thank you!

@Alex-302 could you please open a PR?

Also, for the FutaFilter URL Privacy Guardner List we may need to wait until FiltersCompiler is finally updated. Same thing as with @DandelionSprout's #401 -- we need a way to not exclude it from iOS/Safari/etc filter lists.

@c2xusnpq6
Copy link

Adguard Taiwanese? @ameshkov @AdguardTeam

@DandelionSprout
Copy link
Member

DandelionSprout commented Mar 18, 2021

Personally, I feel that regional lists need at least 200 entries before inclusion, if their languages has more than 1 million speakers. A mere 69 entries is a bit short of that.

I'm also unsure if the maintainer knows the Western meaning of the word "futa".

@Yuki2718
Copy link
Contributor Author

I'm also unsure if the maintainer knows the Western meaning of the word "futa".

OMG I didn't know too.

@tasi788
Copy link

tasi788 commented Mar 19, 2021

@DandelionSprout

We knows what "futa" meaning actually.
When we created this rule, the Interspecies Reviewers (may contain NSFW content not sure) anime was very popular in Taiwan. and theres a cute character called "Crimvael", and our team really like ze (We don't know the gender, so we use ze) so our team agreed that this list should be called "futafilter"

Please let us know if the word "futa" is potentially offensive, and we plan to add the "futafilter" naming convention to the readme of the repo.

@DandelionSprout
Copy link
Member

Ah. It's not actually considered offensive in general settings, but it can cause some "LOL" and "Uh..."

@DandelionSprout
Copy link
Member

As for the amount of entries, spending a few hours going through the top ~200 sites of https://domaintyper.com/top-websites/most-popular-websites-with-tw-domain, can increase the amount of entries a bit.

@tasi788
Copy link

tasi788 commented Mar 19, 2021

As for the amount of entries, spending a few hours going through the top ~200 sites of https://domaintyper.com/top-websites/most-popular-websites-with-tw-domain, can increase the amount of entries a bit.

Thanks for the suggestion, I am planning to add more rules during work breaks.

@zloyden
Copy link
Contributor

zloyden commented Jul 21, 2022

@tasi788 Hi! I have looked at your filters and they are good. Note, that your list contains some JS rules and they won't work in our products due to trust-level option.
In that case, you can exchange some of them. Please see our scriptlets.
For instance, this udn.com#%#if (typeof localStorage != 'undefined' && localStorage.setItem) { localStorage.setItem('bd2021-read-news', '1'); } should work fine like this.

udn.com##%#//scriptlet('set-local-storage-item', 'bd2021-read-news', '1')

Please let us know if the word "futa" is potentially offensive, and we plan to add the "futafilter" naming convention to the readme of the repo.

I don't think that we can use futa in the filter name. Do you have any alternatives?

@zloyden
Copy link
Contributor

zloyden commented Jul 21, 2022

@tasi788 https://filter.futa.gg/filter.txt
Doesn't seem to have been updated. If you still maintain this, please write in this task.

Screenshot:

image


@zloyden zloyden closed this as completed Jul 21, 2022
@tasi788
Copy link

tasi788 commented Jul 22, 2022

I will find time to read and update it recently

@tasi788
Copy link

tasi788 commented Jul 25, 2022

Hi @zloyden,
I've add more rule kill ads, tacker and remove javascript in list. and we've rename FutaFilter to LowTechFilter. Please let me know if there any idea & problem we need to do.
https://github.com/FutaGuard/FutaFilter/commits/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants