Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The strange form of GOPROXY variable in Makefile. #408

Open
hongyi-zhao opened this issue Aug 3, 2024 · 0 comments
Open

The strange form of GOPROXY variable in Makefile. #408

hongyi-zhao opened this issue Aug 3, 2024 · 0 comments

Comments

@hongyi-zhao
Copy link
Contributor

hongyi-zhao commented Aug 3, 2024 •
edited
Loading

Is the following usage of GOPROXY correct?

dnsproxy/Makefile

Line 26 in 791906e

GOPROXY = https://proxy.golang.org|direct

Shouldn't it be written as follows?

GOPROXY = https://proxy.golang.org,direct

See #407 (comment) for the related discussion.

Regards,
Zhao
@hongyi-zhao hongyi-zhao changed the title The strange form of GOPROXY set in Makefile. The strange form of GOPROXY variable in Makefile. Aug 3, 2024
@hongyi-zhao hongyi-zhao mentioned this issue Aug 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hongyi-zhao