Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Support for 1.7.10 using custom lwjgl patches #62

Open
mazunki opened this issue Apr 29, 2024 · 4 comments
Open

[documentation] Support for 1.7.10 using custom lwjgl patches #62

mazunki opened this issue Apr 29, 2024 · 4 comments

Comments

@mazunki
Copy link
Contributor

mazunki commented Apr 29, 2024

This issue is mostly just for documentation purposes, in case anyone runs into the same issue as I did.

So I'm playing Gregtech: New Horizons as of lately, which runs on Minecraft 1.7.10. It uses a custom version of lwjgl, which effectively turned this patch (or the similar USE=wayland-only on Gentoo) on Wayland incompatible.

I had to use the bundled version of lwjgl, because of a missing glfwInitAllocator function (introduced in =glfw-3.4). I wonder if @eigenraven can confirm they're using glfw-3.4 in the bundled version.

In any regard, manually upgrading to glfw-3.4, which I'm going to get merged on ::gentoo (with USE="wayland"), using the system GLFW version just works (and is compatible with her lwjgl patches). Wayland native, no patches! :D

@mazunki mazunki changed the title [documentation] Support for 1.7.10 using custom lwgjl patches [documentation] Support for 1.7.10 using custom lwjgl patches Apr 29, 2024
@eigenraven
Copy link

I use upstream LWJGL3 following Minecraft vanilla snapshots, currently at 3.3.2, will soon update to 3.3.3. https://github.com/LWJGL/lwjgl3/releases/tag/3.3.2 seems to indicate it's glfw 3.3.8, but I know that the lwjgl teams puts its own patches on top of the upstream glfw here https://github.com/LWJGL-CI/glfw

@mazunki
Copy link
Contributor Author

mazunki commented Apr 29, 2024

Interesting, they must've backported/cherrypicked that change, then? Also good to know lwjgl may eventually reach glfw-3.4 too. Is it true that lwjgl is just the java interface into glfw, or am I misunderstanding the relationship?

@eigenraven
Copy link

yes, lwjgl3 is mostly Java/JNI bindings to native libraries, with very little logic of its own

@mazunki
Copy link
Contributor Author

mazunki commented Dec 7, 2024

Thanks :)

I have realized since the last time I commented here that Cleanroom runs under XWayland for me, even if it seems like Wayland is supported by Cleanroom/lwjgl3ify. I haven't dug too deep into this rabbit hole, but I'll soon have some time to dig up this nest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants