Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add member Role Changes to their profile History #1533

Open
Rvice opened this issue Dec 6, 2023 · 7 comments
Open

Add member Role Changes to their profile History #1533

Rvice opened this issue Dec 6, 2023 · 7 comments

Comments

@Rvice
Copy link
Contributor

Rvice commented Dec 6, 2023

Is your feature request related to a problem? Please describe.
There are times when we adjust a members roles, either historically (to correct records we didn't have at the time of setup) or more often than not, accidentally removing a role. It would be nice to see this in the members change history.

Describe the solution you'd like
Add role deletions/additions/changes to the Change History on a member record.

No other alternatives or additional context

@Fasse
Copy link
Member

Fasse commented Dec 6, 2023

This feature is already implemented in version 4.3 through issue #1477

@Fasse Fasse closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2023
@Fasse Fasse added the duplicate label Dec 6, 2023
@Fasse
Copy link
Member

Fasse commented Dec 30, 2023

I'm sorry, I don't understood your request. We don't have the role changes in the profile field history. Within version 4.3 we don't delete the former role assignments. So I reopen this issue.

@Rvice
Copy link
Contributor Author

Rvice commented Dec 30, 2023

If you're on the users profile and you click "change history" roles are not included. This is what the request was for.

I'll need to take a look at 4.3 and see how it tracks.

The issue I had was a bit around Role Leaders and changes from year-to-year. When I set a new role leader, it seems to go back to the first day that person was in that role, instead of the period of time that they were the leader.

@Fasse Fasse removed the duplicate label Dec 31, 2023
@Fasse
Copy link
Member

Fasse commented Dec 31, 2023

Within version 4.3 the former roles area in the profile should store the complete roles history e.g.
Association's board 22.03.2023-31.12.9999
Association's board - Leader 08.05.2022-21.03.2023
Association's board 07.09.2021-07.05.2022
Association's board 07.02.2017-04.11.2018

@Rvice
Copy link
Contributor Author

Rvice commented Jan 2, 2024

Does this include "deleted" roles? i.e. sometimes we make a mistake and assign someone a role that we shouldn't have.

I did a test in Playground (4.3.0 Beta 5) and it does not have this history (total delete) anywhere that I could find. Here's a user in playground that I removed roles from:
https://www.admidio.org/playground/adm_program/modules/profile/profile.php?user_uuid=93ce816e-7cfd-45e1-b025-a3644828c47c

@Fasse
Copy link
Member

Fasse commented Jan 2, 2024

Deleted membership will not be shown in this history.

@Rvice
Copy link
Contributor Author

Rvice commented Jan 8, 2024

That's what this request is for, it's for an admin to see who is deleting things. i.e. a delete audit log in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants