Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log level fine-tuning #230

Open
rokf opened this issue Oct 16, 2020 · 3 comments
Open

Log level fine-tuning #230

rokf opened this issue Oct 16, 2020 · 3 comments
Labels

Comments

@rokf
Copy link

rokf commented Oct 16, 2020

Hey, I propose that some kind of log level configuration logic is added to at least the gosqs part of the application.

There are two logs that are especially bothering me:

https://github.com/p4tin/goaws/blob/6ecd9bf473ad2b2a88dba5224957826665710dec/app/gosqs/gosqs.go#L401

https://github.com/p4tin/goaws/blob/6ecd9bf473ad2b2a88dba5224957826665710dec/app/gosqs/gosqs.go#L451

As the SQS instance is waiting for messages it is spamming out useless logs every second. This can be costly in certain deployment scenarios.

How about introducing an error log level?

I've also noticed that the flag configuration logic in https://github.com/p4tin/goaws/blob/7aca39ed52f1b6b5ad83767a5dd6dc320fea8c8d/app/cmd/goaws.go#L22 is mentioning that the warning level is the default log level, however that is not true - it's the info level.

@Admiral-Piett
Copy link
Owner

Good point rokf no reason to print anything at this point. We can make these debug level logs, and clean up the help logic.

@attilah
Copy link

attilah commented Sep 26, 2024

@Admiral-Piett I came for the very same thing ;-) looking for significant log entries (there IS a message) is hard in an ever scrolling window - which I have no control over.

@Admiral-Piett
Copy link
Owner

Yeah I think I got rid of most of the prints in the 0.5.0 release, but I still need to sweep the code for the rest. Sorry about that. If there are some that are particularly troublesome let me know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants