Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-cpufreq doesn't check the state of hwp_dynamic_boost, and so wrongly reports that EPP is not supported #622

Closed
PhoenixCausesOof opened this issue Jan 9, 2024 · 2 comments

Comments

@PhoenixCausesOof
Copy link
Contributor

When I run auto-cpufreq --stats or use the GUI, it reports to me “Not setting EPP (not supported by system)”. I, of course, had no doubt that my system supported this feature, so I went to check the source code.

Apparently, in this line, it checks whether the file intel_pstate/hwp_dynamic_boost exists — and if it does, reports this error message. That happened to be the case, but just checking whether the file exists isn't enough to accurately determine if dynamic boosting is enabled. The code should, in fact, check the contents of the file (whether a 0 or a 1), and proceed from there.

$ cat /sys/devices/system/cpu/intel_pstate/hwp_dynamic_boost
0
$ auto-cpufreq --stats
Linux distro: Fedora Linux 39 Workstation Edition
Linux kernel: 6.6.10-cb1.0.fc39.x86_64
Processor: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
Cores: 8
Architecture: x86_64
Driver: intel_pstate

------------------------------ Current CPU stats ------------------------------

CPU max frequency: 2400 MHz
CPU min frequency: 400 MHz

Core	Usage	Temperature	Frequency
CPU0      9.1%        44 °C       400 MHz
CPU1      3.1%        44 °C      2242 MHz
CPU2      5.0%        43 °C       400 MHz
CPU3      9.2%        51 °C       400 MHz
CPU4      4.0%        44 °C       400 MHz
CPU5      5.1%        44 °C      2175 MHz
CPU6     10.5%        43 °C      2114 MHz
CPU7     26.5%        51 °C      2320 MHz

---------------------------- CPU frequency scaling ----------------------------

Battery is: charging

Setting to use: "performance" governor
Not setting EPP (not supported by system) <---------------

Total CPU usage: 6.0 %
Total system load: 0.44
Average temp. of all cores: 45.50 °C 

High CPU load (load average: 0.44, 0.49, 0.61)
setting turbo boost: on
@AdnanHodzic
Copy link
Owner

You're right, and in #619 I even mentioned seeing EPP just fine.

Since I'm very limited with available time to do this myself and project is looking for contributors if you or anyone else wants to give it a try in implementing this functionality, please give it a try and contribute to the project and you will be credited for your work as part of future release.

@PhoenixCausesOof
Copy link
Contributor Author

I've created a PR (#631)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants