Docker images are built even if there is no changes in corresponding Dockerfiles

[lde-avaleo]

Hi Guys!

Last year I've reported some anoying behaviour with dockerhub images releases: #307

Has something changed recently as I noticed images are build almost every day????

regards

[lde-avaleo]

This is how renovate PR looks like since some time making it unusable...

[bharathappali]

Has something changed recently as I noticed images are build almost every day????

Can you please point to a specific build where you noticed this ?

[lde-avaleo]

I've noticed it in docker hub where apline-jre image is getting new hash every day. It means that new image was published to dockerhub. I'm guessing that images are published by your build process.

[karianna]

CC @gdams - pretty sure our pipelines don't do this unless this happened as part of a GH actions shift?

[gdams]

Yeah, we update the docker images daily. This is to pull in OS security updates etc.

[bharathappali]

I might be wrong but in the logs i see this

INFO: Building adoptopenjdk/openjdk11 x86_64-alpine-jre-11.0.10_9 from 11/jre/alpine/Dockerfile.hotspot.releases.full ...
INFO: Checking when the adopt docker image x86_64-alpine-jre-11.0.10_9adoptopenjdk/openjdk11:x86_64-alpine-jre-11.0.10_9 was built ...
INFO: AdoptOpenJDK docker image for x86_64-alpine-jre-11.0.10_9adoptopenjdk/openjdk11:x86_64-alpine-jre-11.0.10_9 does not exist. Docker build needed

From the scripts i see

function check_adopt_image_available() {
        local tag=$1

        echo "INFO: Checking when the adopt docker image ${tag} was built ..."
        if ! docker pull "${tag}" &>/dev/null; then
                # Adopt image not available currently, build needed
                echo "INFO: AdoptOpenJDK docker image for ${tag} does not exist. Docker build needed"
                build_needed=1
                return;
        fi
}

The tag var passed to the function should be ideally adoptopenjdk/openjdk11:x86_64-alpine-jre-11.0.10_9 but x86_64-alpine-jre-11.0.10_9adoptopenjdk/openjdk11:x86_64-alpine-jre-11.0.10_9 is getting passed (the tag part is getting prepended to the image name). I feel that the docker pull for x86_64-alpine-jre-11.0.10_9adoptopenjdk/openjdk11:x86_64-alpine-jre-11.0.10_9 fails so the build is getting generated everytime and the images are being updated.

I feel this was the issue for images getting built daily. Please correct me if I'm wrong.

[gdams]

@dinogun any thoughts?

[dinogun]

It appears to me that the recent summary tag changes might have caused this breakage, @bharathappali is investigating and is close to a PR.

[lde-avaleo]

Hmmm I think the issue is stille there. Images where published to docker hub yesterday and today.

[karianna]

@bharathappali Can you review?

[bharathappali]

@lde-avaleo I have raised a new issue stating this #511. It will be fixed in #512 I'm working on it. Will keep it updated.

[lde-avaleo]

Hi Guys!

Any news regarding this one? The issue is still there...