Skip to content

Commit fd351cb

Browse files
authored
fix: add response to permission error for easier debugging (#116)
1 parent a3e6eca commit fd351cb

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

lib/adyen/client.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def call_adyen_api(service, action, request_data, headers, version, with_applica
169169
when 401
170170
raise Adyen::AuthenticationError.new("Invalid API authentication; https://docs.adyen.com/user-management/how-to-get-the-api-key", request_data)
171171
when 403
172-
raise Adyen::PermissionError.new("Missing user permissions; https://docs.adyen.com/user-management/user-roles", request_data)
172+
raise Adyen::PermissionError.new("Missing user permissions; https://docs.adyen.com/user-management/user-roles", request_data, response.response_body)
173173
end
174174

175175
formatted_response = AdyenResult.new(response.body, response.headers, response.status)

lib/adyen/errors.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ def initialize(msg, request)
7070
end
7171

7272
class PermissionError < AdyenError
73-
def initialize(msg, request)
74-
super(request, nil, msg, 403)
73+
def initialize(msg, request, response)
74+
super(request, response, msg, 403)
7575
end
7676
end
7777

spec/errors_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
expect(Adyen::AdyenError.new(@shared_values[:request], nil, nil, 'code').to_s).to eq("Adyen::AdyenError code:code, request:#{@shared_values[:request]}")
3434
end
3535
it 'uses the proper error class name' do
36-
expect(Adyen::PermissionError.new('message', @shared_values[:request]).to_s).to eq("Adyen::PermissionError code:403, msg:message, request:#{@shared_values[:request]}")
36+
expect(Adyen::PermissionError.new('message', @shared_values[:request], 'response').to_s).to eq("Adyen::PermissionError code:403, msg:message, request:#{@shared_values[:request]}, response:response")
3737
end
3838
end
3939
describe '#masking' do

0 commit comments

Comments
 (0)