Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling Charon with the proper options is too hard #377

Closed
sonmarcho opened this issue Dec 2, 2024 · 3 comments · Fixed by #379
Closed

Calling Charon with the proper options is too hard #377

sonmarcho opened this issue Dec 2, 2024 · 3 comments · Fixed by #379

Comments

@sonmarcho
Copy link
Member

I see too many people calling Charon with the wrong options (especially without the --hide-marker-traits): we should do something about it. First, the README doesn't explicitly say with which options to call Charon. Second, I think we should find a way of helping users notice that the options are wrong. In the long term we should of course make Aeneas directly call Charon, but in the meantime I was thinking that maybe we could also serialize the options with which Charon was called, to check them on Aeneas' side and raise a warning/error if we detect an option which is incompatible with Aeneas' extraction (in particular, detect that Charon was called with --hide-marker-traits).

@sonmarcho
Copy link
Member Author

@Nadrieril what do you think?

@Nadrieril
Copy link
Member

Oh, that's a great idea!

@Nadrieril Nadrieril self-assigned this Dec 2, 2024
@sonmarcho
Copy link
Member Author

Ok let's do that then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants