-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable sentences with features #91
Comments
I guess this will be a breaking change? If we make |
Valid point. Yes it will be, but we'll bump version to default = ["std", "all-sentences"]
all-sentences = ["...", "vendor-specific"]
vendor-specific = [".."]
...
..
. |
What about usage of macros instead of features? Something like
and that generate nmea parser that parse only Plus it would be nice implement the similar fnctionality for This variant of dealing with redundant code allows the compiler to solve the unnecessary code problem, |
@Dushistov macros might make it more difficult to use the crate and contribute to the project IMO. It's tedious process to add these features now but explicitly listing them sounds like a very good approach. |
There's one more additional benefit that I though of. Compiler will still optimize and remove the unused parser/code, however, if you want to parse a specific sentences in your project which you have excluded from |
In my case, I use my own |
These sentences features have been implemented in #94 . Closing this issue for now as it's Done ✔️ . |
We should have all sentences enabled with a feature, e.g. "all-sentences", however, it should be possible to parse only a subset of sentences by enabling only their own feature, e.g.
gll
orgsv
, etc.This will ensure that the size of the crate is optimised for highly constraint targets which require some subset of the sentences.
This is related to #54
The text was updated successfully, but these errors were encountered: