Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement moving filter on WatchDog #3

Open
kh9sd opened this issue Sep 22, 2023 · 0 comments
Open

Implement moving filter on WatchDog #3

kh9sd opened this issue Sep 22, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@kh9sd
Copy link
Member

kh9sd commented Sep 22, 2023

Currently, our FakeWatchDog implementation will instantly freak out if it gets passed a bad SensorData once.

This might sound good, but it's not useful because it will take time for pressure and temperature readings to transition after a state change, so our WatchDog will probably trip every time we change states.

Implement a storage of past SensorDatas in a new WatchDog class, oldest will be replaced by newest so probably a queue. We will then average/use the median of sensor data readings across all SensorDatas in storage, and use that averaged SensorData to run redlines on.

@kh9sd kh9sd added the enhancement New feature or request label Sep 22, 2023
@allenyxu2004 allenyxu2004 self-assigned this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants