Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Weird Memory Retention from Sherpa #287

Closed
20001LastOrder opened this issue Feb 2, 2024 · 1 comment · Fixed by #277
Closed

[BUG] Weird Memory Retention from Sherpa #287

20001LastOrder opened this issue Feb 2, 2024 · 1 comment · Fixed by #277
Assignees
Labels
bug Something isn't working

Comments

@20001LastOrder
Copy link
Collaborator

Describe the bug
In the Slack Channel, Sherpa responded to a question with an irrelevant search:
image

After some investigation, it seems this query was also used to answer another question earlier:
image

So for some reason, the memory is retained from the last question to this question. However, this seems to happen rarely so more investigation is necessary.

To Reproduce
Unclear

Expected behavior
Sherpa should answer the second question by searching with a relevant query

@20001LastOrder 20001LastOrder added the bug Something isn't working label Feb 2, 2024
@20001LastOrder 20001LastOrder linked a pull request Feb 5, 2024 that will close this issue
@20001LastOrder
Copy link
Collaborator Author

It seems this line:

belief: Belief = Belief(),

causes all QA agents with default beliefs to share the same belief. I think this may be the cause of the issue. There is already a fix implemented in the above PR mentioned in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant