-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog (2/14) #92
Comments
angular-a11y-dialoghttps://www.npmjs.com/package/angular-a11y-dialog And I've got it working in AgnosticUI angular package (not published in docs site yet) svelte-a11y-dialoghttps://www.npmjs.com/package/svelte-a11y-dialog vue-a11y-dialoghttps://github.com/AgnosticUI/vue-a11y-dialog/tree/vue-3 Was attempting to push back upstream. See discussion here: PR's been sitting for a while with no feedback: UPDATE: vue-a11y-dialog in morko is now updated and working! |
I'm electing to mark this task as DONE even though there are some minor loose ends:
However, I want to close this out in the spirit of iteration and forward progress. I have stated in the docs for svelte and angular something to the affect of:
I'll get back to these things but want to feel unstuck and have started on Toasts for now :) |
Can we leverage a11y-dialog?
Can we share logic for Drawers and Toasts? TODO: research aria and a11y for drawers and toasts and see if the variation is small enough so that we can reuse logic.
This is now also including helping with upstream work on
vue-a11y-dialog
and creating asvelte-a11y-dialog
andangular-a11y-dialog
. It's actually much easier then getting the JavaScript correct from scratch,a11y-dialog
is well maintained and battle-tested and finally light-weighta11y-dialog
et alI'm removing following requirement for this task:
- [ ] Still need to add Cypress tests to svelte-a11y-dialog then publishAnd moving that to the svelte-a11y-dialog tracker:
AgnosticUI/svelte-a11y-dialog#1
The text was updated successfully, but these errors were encountered: