Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog (2/14) #92

Closed
12 tasks done
roblevintennis opened this issue Dec 28, 2021 · 2 comments
Closed
12 tasks done

Dialog (2/14) #92

roblevintennis opened this issue Dec 28, 2021 · 2 comments
Assignees
Labels
Done Something that is complete enhancement New feature or request
Milestone

Comments

@roblevintennis
Copy link
Contributor

roblevintennis commented Dec 28, 2021

Can we leverage a11y-dialog?

Can we share logic for Drawers and Toasts? TODO: research aria and a11y for drawers and toasts and see if the variation is small enough so that we can reuse logic.

This is now also including helping with upstream work on vue-a11y-dialog and creating a svelte-a11y-dialog and angular-a11y-dialog. It's actually much easier then getting the JavaScript correct from scratch, a11y-dialog is well maintained and battle-tested and finally light-weight

  • CSS
  • React
  • React Examples
  • Upstream contributions to a11y-dialog et al
  • Vue 3
  • Vue Examples
  • Svelte
  • Svelte Examples
  • Angular
  • Angular Examples
  • Site Docs
  • Publish frameworks and npm packages

I'm removing following requirement for this task:
- [ ] Still need to add Cypress tests to svelte-a11y-dialog then publish

And moving that to the svelte-a11y-dialog tracker:
AgnosticUI/svelte-a11y-dialog#1

@roblevintennis roblevintennis added the enhancement New feature or request label Dec 28, 2021
@roblevintennis roblevintennis self-assigned this Dec 28, 2021
@roblevintennis roblevintennis added this to the MVP milestone Dec 28, 2021
@roblevintennis roblevintennis changed the title Dialog (5/7) Dialog (1/14) Jan 4, 2022
@roblevintennis roblevintennis changed the title Dialog (1/14) Dialog (1/21) Jan 4, 2022
@roblevintennis roblevintennis moved this to Todo in AgnosticUI MVP Jan 4, 2022
@roblevintennis roblevintennis added the In Progress Indicates a issue in progress label Jan 7, 2022
@roblevintennis roblevintennis moved this from Todo to In Progress in AgnosticUI MVP Jan 7, 2022
@roblevintennis
Copy link
Contributor Author

roblevintennis commented Jan 21, 2022

angular-a11y-dialog

https://www.npmjs.com/package/angular-a11y-dialog
"version": "0.0.4",
"homepage": "https://github.com/AgnosticUI/angular-a11y-dialog",

And I've got it working in AgnosticUI angular package (not published in docs site yet)

svelte-a11y-dialog

https://www.npmjs.com/package/svelte-a11y-dialog

vue-a11y-dialog

https://github.com/AgnosticUI/vue-a11y-dialog/tree/vue-3

Was attempting to push back upstream. See discussion here:
morkro/vue-a11y-dialog#28

PR's been sitting for a while with no feedback:
morkro/vue-a11y-dialog#31
🤔

UPDATE: vue-a11y-dialog in morko is now updated and working!

@roblevintennis roblevintennis changed the title Dialog (1/21) Dialog (1/31) Jan 26, 2022
@roblevintennis roblevintennis changed the title Dialog (1/31) Dialog (2/14) Feb 7, 2022
@roblevintennis
Copy link
Contributor Author

I'm electing to mark this task as DONE even though there are some minor loose ends:

  1. I plan to have test coverage added to the svelte-a11y-dialog adapter but I'm awaiting Vite + Cypress plugin support
  2. Angular dialog should be used for several months until it's considered ready and probably was given the least amount of effort

However, I want to close this out in the spirit of iteration and forward progress. I have stated in the docs for svelte and angular something to the affect of:

Please consider <Angular|Svelte> Dialog experimental and not yet ready for production

I'll get back to these things but want to feel unstuck and have started on Toasts for now :)

Repository owner moved this from In Progress to Done in AgnosticUI MVP Feb 12, 2022
@roblevintennis roblevintennis added Done Something that is complete and removed In Progress Indicates a issue in progress labels Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Something that is complete enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant