Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key-up events can include the wrong keycode #287

Open
stevesims opened this issue Feb 4, 2025 · 0 comments
Open

Key-up events can include the wrong keycode #287

stevesims opened this issue Feb 4, 2025 · 0 comments

Comments

@stevesims
Copy link
Contributor

The current keyboard handling code keeps track of the "keycode" (ASCII) value for the last key-down event, and will use that as the keycode for the keyboard packet sent to MOS for key-up events, rather than sending the correct keycode for the key that has been release.

This is problematic, as it means that if multiple keys have been pressed down the key-up packets can indicate the wrong key has been released.

This doesn't really affect MOS's keyboard handling as that uses the VK data.

Ideally the VDP should return a keycode that equates to the key being released.

It is suspected that the current behaviour seems to be in place to ensure that an ASCII value is present when a modifier key is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant