Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: some defined issues
Browse files Browse the repository at this point in the history
API `startEchoTest`
Event `AirPlayIsConnected` & `VirtualBackgroundSourceEnabled`
LichKing-2234 committed Dec 22, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 34b576e commit 30a9f36
Showing 2 changed files with 31 additions and 21 deletions.
14 changes: 12 additions & 2 deletions src/common/RtcEngine.native.ts
Original file line number Diff line number Diff line change
@@ -2379,8 +2379,18 @@ export default class RtcEngine implements RtcEngineInterface {
* - In the [`LiveBroadcasting`]{@link ChannelProfile.LiveBroadcasting} profile, only a host can call this method.
* @param intervalInSeconds The time interval (s) between when you speak and when the recording plays back.
*/
startEchoTest(intervalInSeconds: number): Promise<void> {
return RtcEngine._callMethod('startEchoTest', { intervalInSeconds });
startEchoTest(
intervalInSeconds?: number,
config?: EchoTestConfiguration
): Promise<void> {
console.assert(
intervalInSeconds === undefined || config === undefined,
'Only need one of the params'
);
return RtcEngine._callMethod('startEchoTest', {
intervalInSeconds,
config,
});
}

/**
38 changes: 19 additions & 19 deletions src/common/RtcEvents.ts
Original file line number Diff line number Diff line change
@@ -1469,6 +1469,25 @@ export interface RtcEngineEvents {
*/
UploadLogResult: UploadLogResultCallback;

/**
* @ignore
*/
AirPlayIsConnected: EmptyCallback;

/**
* Reports whether the virtual background is successfully enabled. (beta function)
*
* **since** v3.5.0.3
*
* After you call [`enableVirtualBackground`]{@link enableVirtualBackground}, the SDK triggers this callback to report whether the virtual background is successfully enabled.
*
* **Note**
*
* If the background image customized in the virtual background is in PNG or JPG format, the triggering of this callback is delayed until the image is read.
*
*/
VirtualBackgroundSourceEnabled: VirtualBackgroundSourceEnabledCallback;

/**
* Reports the information of an audio file.
*
@@ -1865,23 +1884,4 @@ export interface RtcChannelEvents {
* After calling `enableRemoteSuperResolution`, the SDK triggers this callback to report whether the super-resolution algorithm is successfully enabled. If not successfully enabled, you can use `reason` for troubleshooting.
*/
UserSuperResolutionEnabled: UserSuperResolutionEnabledCallback;

/**
* @ignore
*/
AirPlayIsConnected: EmptyCallback;

/**
* Reports whether the virtual background is successfully enabled. (beta function)
*
* **since** v3.5.0.3
*
* After you call [`enableVirtualBackground`]{@link enableVirtualBackground}, the SDK triggers this callback to report whether the virtual background is successfully enabled.
*
* **Note**
*
* If the background image customized in the virtual background is in PNG or JPG format, the triggering of this callback is delayed until the image is read.
*
*/
VirtualBackgroundSourceEnabled: VirtualBackgroundSourceEnabledCallback;
}

0 comments on commit 30a9f36

Please sign in to comment.