-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting the background Image #185
Comments
seem like you are using v1.x, you should use addVideoWatermark |
I am using v1.x as version 3.x was not production-ready. So to be absolutely clear, to set the privacy background image you are suggesting that we should be adding a video watermark? |
setLiveTranscoding is for CDN live. |
I am trying to remove the background behind the caller (similar to Zoom) not to add a watermark. |
I think you should process video capture raw data before publishing. |
But access to raw data is not available in the Flutter plug-in |
Yes, it is in planning, but now, you can only implement it in the native layer. |
Thanks. Do you have an estimated timeframe for that? It is just that many of us (myself included), we use Flutter to avoid diving into the native layer as we only have the expertise in iOS or Android. Even for some newer recruits, Flutter is the only mobile app experience that they have had and they have never played with the native layer. |
@rgb1380 the problem is for certain features you have to touch native layer to achieve best performance, especially for native raw data processing. It's not reasonable to pass the raw video data to dart layer for you to process and return to native layer, most background replacement sdk also supports native layers only. |
A couple of thoughts, if the bottleneck is IO. There are several trade-offs that could be made:
|
@rgb1380 thank you for the suggestion. but it's hard to control how customer will use it and to best of my knowledge 5fps or lower resolution will fail to satisfy most customer needs like face beautification, customized recording etc, plus the preprocessing(compress/resample) cost CPU performance too. Real time video is very different from simple image processing, the experience is extremely important especially when you need to consider low-end devices. In this case from my perspective the best practice is still to do all this in native layer. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please raise a new issue. |
Trying to see how the privacy background image works
I have put this after I enable video.
Nothing happens. The documentation is a bit lacking. Not sure if this is how it is supposed to be used.
I am only trying to add a background image, however, AgoraLiveTranscoding has a toJson method that will try to read from watermark and also map transcodingUsers and if these do not exist will throw a null exception. So I had to add a water mark and an empty transcodingUsers list. Here is the toJson method for reference. If these fields are optional this needs to be fixed.
The text was updated successfully, but these errors were encountered: