fix: Fix a potential crash in AgoraVideoView when the app is force quit #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littleGnAl
force-pushed
the
littlegnal/fix-agoravideoview-crash-when-app-terminate
branch
from
4ca9f3e to
bc18e71
Compare
littleGnAl
deleted the
littlegnal/fix-agoravideoview-crash-when-app-terminate
branch
peilinok
pushed a commit
that referenced
this pull request
Dec 6, 2024
…it (#2055) If an `AgoraVideoView` is displayed and a video frame callback is received while the app is quitting, there is a potential crash risk due to access to invalid resources(invalid adresses) in the callback. To prevent this, we should ensure that resources are properly cleaned up in the destructor. This logic is already handled in the Windows implementation, so in this PR, we are updating it for Android, iOS, and macOS only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an
AgoraVideoViewis displayed and a video frame callback is received while the app is quitting, there is a potential crash risk due to access to invalid resources(invalid adresses) in the callback. To prevent this, we should ensure that resources are properly cleaned up in the destructor.This logic is already handled in the Windows implementation, so in this PR, we are updating it for Android, iOS, and macOS only.