Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding getConnectionState #145

Closed
marqroldan opened this issue Apr 1, 2020 · 1 comment · Fixed by #146
Closed

Question regarding getConnectionState #145

marqroldan opened this issue Apr 1, 2020 · 1 comment · Fixed by #146

Comments

@marqroldan
Copy link

react-native-agora: 2.9.1-alpha.3

Not sure about how it is presented in iOS as I don't have a mac to test and check, but on Android I am getting the connection state as an error.

Checking the iOS code it seems that it's right to resolve it (rather than having a reject block).
But on Android, the code seems to always reject it because res will never equal to 0 (because it's a promise?) and would otherwise resolve null if it did equal to 0

I have no experience in native coding, but I probably can follow pattern; I'll try to make a pull request.

@LichKing-2234
Copy link
Collaborator

thank you for your PR, we will upgrade later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants