Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][4.x] MediaStreamInfo duration attribute #1378

Closed
kevin-rabefaritra opened this issue May 16, 2023 · 3 comments
Closed

[Android][4.x] MediaStreamInfo duration attribute #1378

kevin-rabefaritra opened this issue May 16, 2023 · 3 comments
Assignees

Comments

@kevin-rabefaritra
Copy link

Business case: Specify the correct unit used by the duration attribute of MediaStreamInfo.

Subject Matter Expert:

  • Technical:
  • Language: Iain
  • PM: only if essential

Scope:
Doc link: https://api-ref.agora.io/en/video-sdk/android/4.x/API/class_playerstreaminfo.html

Since 4.x, the the duration attribute of MediaStreamInfo is in milliseconds, instead of seconds.
This may affect the implementation logic in case of misuse.

Acceptance criteria: The documentation is corrected.

Additional valuable information:
I have tested to read the attribute and can confirm the value is returned in milliseconds.

@kevin-rabefaritra kevin-rabefaritra changed the title MediaStreamInfo duration attribute [Android][4.x] MediaStreamInfo duration attribute May 16, 2023
@dengyaxi
Copy link
Contributor

Hi @billy-the-fish. Just a quick heads up! If there's any GitHub issue related to the 4.x API reference, please assign it to me if it's for the web platform. For other platforms, please assign it to Luodan.

@billy-the-fish
Copy link
Contributor

Done, thank you @dengyaxi .

@Cilla-luodan
Copy link

The doc source is updated. Please use this tag for publish: https://github.com/AgoraIO/agora_doc_source/releases/tag/v4.2.0-bugfix-0608

It is also mentioned in this issue: #1405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants