Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal Implementation #2

Open
nixnull opened this issue May 25, 2017 · 6 comments
Open

Minimal Implementation #2

nixnull opened this issue May 25, 2017 · 6 comments

Comments

@nixnull
Copy link
Member

nixnull commented May 25, 2017

I've written a minimal implementation of this in the GH Pages/Jekyll style.

Repo here: https://github.com/nichdel/pagetesting

Page example here: https://nichdel.github.io/pagetesting/

This keeps the formatting outside of the .md files and should be largely agnostic to our various methods of management.

If it looks good, I'll submit a PR to add instructions to the README.

@Gaelan
Copy link
Member

Gaelan commented May 25, 2017

Only thing missing is support for the active class. You should be able to do {% include 'Header/header.html | replace '__ACTIVE_ADOP__', 'active' %} to highlight "ADoP" but I haven't tested.

@Gaelan
Copy link
Member

Gaelan commented May 25, 2017

Wait, don't think that will work. Can you think of a way?

@nixnull
Copy link
Member Author

nixnull commented May 25, 2017

I'll play around with it and see where we get.

@nixnull
Copy link
Member Author

nixnull commented May 25, 2017

It seems it'd be possible to do include Header/header.html active="ADoP" and use a filter within header.html.

@nixnull
Copy link
Member Author

nixnull commented May 25, 2017

Seems like a lot of extra scaffolding (an if, else, endif block for every spot) to add to the header, tho. Something within the default.html would be great, but I'm not sure includes allows any filtering.

@Gaelan
Copy link
Member

Gaelan commented May 25, 2017

Ya, that was my other thought. I'd need to change the ruleset to work with that, but it could work (either with find/replace or letting GH pages handle it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants